mirror of
https://github.com/dtzp555-max/ocp.git
synced 2026-07-21 21:15:09 +00:00
a37ff713d9
TUI-mode (CLAUDE_TUI_MODE=true) is an OCP-owned subscription-pool bridge for the
2026-06-15 Anthropic billing split. This PR fixes four honesty/robustness defects
confirmed by a prior audit and live-reproduced on PI231 (2026-06-10).
C-1 (P1) — upstream AUTH-FAILURE banner returned/cached as a real answer.
The interactive claude CLI renders in-session errors as ordinary assistant text.
The R-1 case C-1 exists to catch is expired/invalid credentials, where EVERY turn
comes back as the same one-line auth-failure banner, e.g. the two live PI231
banners (2026-06-10):
"Please run /login · API Error: 401 Invalid authentication credentials" (69 chars)
"Failed to authenticate. API Error: 401 Invalid authentication credentials" (73 chars)
callClaudeTui returned that banner verbatim → OCP cached it, shared it via
singleflight, and recorded a model SUCCESS. New detectTuiUpstreamError()
(lib/tui/transcript.mjs) flags such a turn; callClaudeTui throws tui_upstream_error
+ logEvent("error", …) BEFORE recordModelSuccess/cache write-back, so the error
never enters the cache; the client gets a 5xx.
C-1 NARROWING (false-positive probe, 2026-06-10). An earlier generalised default
rule — ^<short auth-failure prefix>?API Error: <3-digit> <detail>$ — was TOO BROAD:
the unbounded ".*" detail tail let any short prefix + "API Error: NNN" + an
arbitrarily long sentence match, so it KILLED legitimate long answers that merely
DISCUSS an API error (e.g. "API Error: 500 happened because the server was
overloaded. To fix this, retry with exponential backoff …"). A false-positive costs
the user a missing answer AND a double-burn retry — strictly worse than the rare
false-negative (caching one transient error for the 5-min TTL). C-1 is therefore
reframed from "detect any API error" to "detect a claude-CLI AUTHENTICATION-FAILURE
banner", and is CONSERVATIVE: when unsure it PASSES. The narrowed default detector
flags a turn only when ALL of the following hold over the WHOLE trimmed text
(a conjunction; any one failing => PASS):
1. SHORT whole-message — length ≤ 100 (live banners are 69/73; cap gives headroom
while rejecting multi-sentence prose; a 226-char auth answer is dropped on
length alone).
2. Contains "API Error: 4\d{2}" — auth failures are 4xx (401/403); transient 5xx
and bare "HTTP 401 means unauthorized." (no API-Error core) are excluded.
3. Contains an auth keyword — authenticat | /login | credential (case-insensitive);
rejects "To debug a 401 … API Error: 401 Unauthorized …" (authoriz-, not
authenticat-).
4. Contains NO backtick/quote char (` ' ") — a real banner is plain text; quoted
text signals an answer QUOTING the error, e.g. "You'll see `API Error: 401` …
run /login to fix it." (short + 4xx + /login, excluded only by this signal).
Full required matrix (2 KILL + 7 PASS) encoded as tests; npm test green.
CLAUDE_TUI_ERROR_PATTERNS still overrides (a non-empty value REPLACES the default
with operator regexes; empty/whitespace DISABLES detection). New fixture
lib/tui/fixtures/error-401-failauth.jsonl + positive/negative tests retained.
C-2 (P1) — wallclock-truncated partial text returned as silent success.
readTuiTranscript returned {text, entrypoint} identically on the terminal-marker
path and the cap-with-partial path, so a cut-off turn was cached + returned as
finish_reason:stop. It now returns truncated:false on terminal-marker and
truncated:true on the cap-with-partial path (additive field; no-text cap path
still throws). callClaudeTui throws tui_wallclock_truncated on truncated.
C-3 (P1) — verifyEntrypoint only read the turn_duration line.
Some claude builds don't emit turn_duration (Mac mini: absent; PI231/2.1.104:
present), while the entrypoint field is on ordinary lines on BOTH. Reading only
turn_duration made the server.mjs tui_entrypoint_mismatch assertion get got:null
every turn on non-emitting builds. verifyEntrypoint now PREFERS the turn_duration
entrypoint and FALLS BACK to the entrypoint field on any line.
C-4 (P2) — short prompts 100% failed paste-landing.
tuiPromptLanded required needle.length >= 3, so a 1–2 char first line ("hi","ok")
never matched and 5s-failed with tui_paste_not_landed every time (live-repro:
"hi"). Threshold lowered 3 → 2; the input box starts empty (placeholder excluded
by the affirmative-signal design) so a 2-char needle present in the pane is the
prompt. Kept >=2 (not >=1) to avoid collisions with claude's chrome glyphs.
Tests: extended test-features.mjs with unit coverage for each fix + three fixtures
(lib/tui/fixtures/error-401.jsonl, error-401-failauth.jsonl, no-turn-duration.jsonl).
The C-1 block now encodes the full narrowed auth-banner matrix (2 must-kill + 7
must-pass + supporting regression guards incl. a length-cap-load-bearing test).
npm test: 224 passed, 0 failed. Default path (CLAUDE_TUI_MODE unset →
upstreamCall=callClaude) is byte-identical: the only server.mjs change is one import
+ the callClaudeTui body, and callClaudeTui is unreachable when TUI_MODE is off.
ALIGNMENT: Class B (OCP-owned compatibility surface). cli.js does not perform this
operation (TUI is an OCP-owned subscription-pool bridge); scope authorized by ADR
0007 (Class B). No Class A path touched (callClaude / handleUsage / OAuth unchanged);
no change to .github/workflows/alignment.yml or any blacklisted token.
Co-authored-by: dtzp555 <dtzp555@gmail.com>
Co-authored-by: Claude <claude-opus> <noreply@anthropic.com>
374 lines
20 KiB
JavaScript
374 lines
20 KiB
JavaScript
// TUI-mode session driver: hosts an interactive `claude` in tmux, submits one
|
||
// serialized prompt, awaits the transcript reader, tears down. OCP-specific.
|
||
//
|
||
// Authority: claude CLI v2.1.158 interactive mode (no -p / no --output-format
|
||
// => cc_entrypoint=cli). Submission recipe validated by spikes T3/T6 on PI231.
|
||
// See docs/superpowers/specs/2026-05-30-tui-mode-production-design.md.
|
||
//
|
||
// Trust handling: rather than answer the trust-folder dialog interactively (which
|
||
// only appears on a cwd's FIRST encounter — sending a defensive "1" to an already
|
||
// trusted cwd would inject a stray prompt turn), we PRE-TRUST the scratch cwd by
|
||
// seeding <home>/.claude.json. Every turn then boots dialog-free and identical.
|
||
import { spawnSync } from "node:child_process";
|
||
import { mkdtempSync, writeFileSync, readFileSync, mkdirSync, existsSync, rmSync, statSync, renameSync, symlinkSync } from "node:fs";
|
||
import { tmpdir } from "node:os";
|
||
import { randomUUID } from "node:crypto";
|
||
import { readTuiTranscript } from "./transcript.mjs";
|
||
|
||
export const SESSION_PREFIX = "ocp-tui-"; // per-proxy namespace (coexistence rule)
|
||
const TMUX = process.env.OCP_TUI_TMUX_BIN || "tmux";
|
||
|
||
const defaultTmux = (args, opts = {}) =>
|
||
spawnSync(TMUX, args, { encoding: "utf8", ...opts });
|
||
|
||
// Kill ONLY our own stale sessions. Scoped to SESSION_PREFIX so a co-hosted
|
||
// OLP test instance's `olp-tui-*` sessions are never touched.
|
||
export function reapStaleTuiSessions({ tmux = defaultTmux } = {}) {
|
||
const r = tmux(["list-sessions", "-F", "#{session_name}"]);
|
||
if (!r || r.status !== 0) return 0; // no tmux server / no sessions
|
||
let killed = 0;
|
||
for (const name of String(r.stdout || "").split("\n").map((s) => s.trim()).filter(Boolean)) {
|
||
if (name.startsWith(SESSION_PREFIX)) {
|
||
tmux(["kill-session", "-t", name]);
|
||
killed++;
|
||
}
|
||
}
|
||
return killed;
|
||
}
|
||
|
||
// ── Task 5: runTuiTurn ───────────────────────────────────────────────────
|
||
|
||
// Boot + paste-settle timing. Conservative defaults validated on PI231; env-tunable.
|
||
const BOOT_MS = parseInt(process.env.OCP_TUI_BOOT_MS || "4000", 10); // max wait for input-ready
|
||
const READY_POLL_MS = parseInt(process.env.OCP_TUI_READY_POLL_MS || "400", 10); // readiness / paste-verify poll interval
|
||
const PASTE_VERIFY_MS = parseInt(process.env.OCP_TUI_PASTE_VERIFY_MS || "5000", 10); // max wait for pasted prompt to render
|
||
|
||
const sleep = (ms) => new Promise((r) => setTimeout(r, ms));
|
||
|
||
// Capture the visible tmux pane as plain text (for readiness / paste verification).
|
||
function tuiCapturePane(tmux, tmuxName) {
|
||
const r = tmux(["capture-pane", "-p", "-t", tmuxName]);
|
||
return (r && typeof r.stdout === "string") ? r.stdout : "";
|
||
}
|
||
|
||
// True once claude's input bar is rendered and ready for keystrokes.
|
||
function tuiInputReady(pane) {
|
||
return /\? for shortcuts/.test(pane);
|
||
}
|
||
|
||
// True once the pasted prompt has POSITIVELY landed in the input box. We only trust
|
||
// affirmative signals — NOT "the placeholder is gone", which is unreliable (claude's
|
||
// placeholder uses a curly quote `"`, randomized example text, and renders the big paste
|
||
// a beat after paste-buffer returns; a "placeholder-gone" heuristic false-positived on the
|
||
// still-empty box and made us submit Enter into nothing → issue #130 hang). Landed iff:
|
||
// (a) the bracketed-paste indicator "[Pasted text" is present (large/multi-line paste), OR
|
||
// (b) the prompt's own leading text appears in the pane (short/literal paste).
|
||
function tuiPromptLanded(pane, prompt) {
|
||
const flatPane = pane.replace(/\s+/g, " ");
|
||
if (flatPane.includes("[Pasted text")) return true;
|
||
const firstLine = String(prompt).split("\n").map(s => s.trim()).find(Boolean) || "";
|
||
const needle = firstLine.replace(/\s+/g, " ").slice(0, 24);
|
||
// C-4/#133: threshold lowered 3 → 2. A prompt whose first non-blank line is 1–2
|
||
// chars ("hi", "ok") previously NEVER matched (needle.length >= 3) and never
|
||
// surfaced "[Pasted text", so EVERY short prompt 5s-failed with tui_paste_not_landed
|
||
// (live-reproduced: "hi"). The input box starts EMPTY (the curly-quote placeholder
|
||
// is excluded by the affirmative-signal design above), so a >=2-char needle present
|
||
// in the pane is the pasted prompt, not placeholder noise — false-positive risk is
|
||
// low. We keep >=2 rather than >=1 because a single visible char is more likely to
|
||
// collide with incidental glyphs in claude's chrome (borders, the "❯" prompt mark);
|
||
// 2 chars is the floor that lands real prompts while staying conservative.
|
||
return needle.length >= 2 && flatPane.includes(needle);
|
||
}
|
||
|
||
async function pollUntil(fn, { timeoutMs, intervalMs }) {
|
||
const deadline = Date.now() + timeoutMs;
|
||
while (Date.now() < deadline) {
|
||
try { if (fn()) return true; } catch { /* ignore, keep polling */ }
|
||
await sleep(intervalMs);
|
||
}
|
||
return false;
|
||
}
|
||
|
||
// Single-quote escaper for sh -c arguments.
|
||
function shq(s) {
|
||
return `'${String(s).replace(/'/g, "'\\''")}'`;
|
||
}
|
||
|
||
// Pre-trust the scratch cwd by seeding the trust record in <home>/.claude.json so
|
||
// the trust-folder dialog never appears. Verified-live trust shape:
|
||
// projects["<cwd>"] = { hasTrustDialogAccepted: true, allowedTools: [], ... }
|
||
// Idempotent + best-effort: a missing/unreadable .claude.json must not abort a
|
||
// turn (a fresh cwd would then show the dialog once; the boot wait tolerates it).
|
||
// Must run BEFORE the session boots so claude reads the trusted record at startup.
|
||
export function ensureTuiCwdTrusted(home, cwd) {
|
||
if (!home || !cwd) return;
|
||
const path = `${home}/.claude.json`;
|
||
let j, mode;
|
||
try {
|
||
j = JSON.parse(readFileSync(path, "utf8"));
|
||
mode = statSync(path).mode & 0o777;
|
||
} catch { return; }
|
||
j.projects = j.projects || {};
|
||
const entry = j.projects[cwd] || {};
|
||
if (entry.hasTrustDialogAccepted === true) return; // already trusted, no rewrite
|
||
entry.hasTrustDialogAccepted = true;
|
||
if (!Array.isArray(entry.allowedTools)) entry.allowedTools = [];
|
||
j.projects[cwd] = entry;
|
||
// Atomic write (temp + rename on the same fs), preserving mode, so a crash
|
||
// mid-write can never truncate the user's real ~/.claude.json. We seed ONLY the
|
||
// per-project trust flag — NOT bypassPermissionsModeAccepted: the driver never
|
||
// passes --dangerously-skip-permissions, so the bypass dialog cannot appear, and
|
||
// onboarding completion is an A-path precondition (the host already runs claude).
|
||
// NOTE: when the A-path moves to a dedicated scratch HOME (task #26), this writes
|
||
// a file we fully own, removing the real-config-mutation concern entirely.
|
||
try {
|
||
const tmp = `${path}.ocp-tui.${process.pid}.tmp`;
|
||
writeFileSync(tmp, JSON.stringify(j, null, 2), { mode });
|
||
renameSync(tmp, path);
|
||
} catch { /* best effort */ }
|
||
}
|
||
|
||
// Prepare the HOME claude runs under. Two modes:
|
||
// - real-home (tuiHome === realHome OR falsy): no isolation; just trust the cwd
|
||
// in the real ~/.claude.json. Opt in by setting OCP_TUI_HOME=$HOME.
|
||
// - scratch-home: a dedicated HOME that reuses the real OAuth via a SYMLINKED
|
||
// .credentials.json, with a seeded .claude.json (onboarded real config minus
|
||
// the user's project history; trusts only the scratch cwd) and its own
|
||
// projects/ dir — so the real ~/.claude is never mutated or polluted.
|
||
//
|
||
// ⚠️ CREDENTIAL CAVEAT (verified live): claude rewrites .credentials.json on token
|
||
// refresh, REPLACING the symlink with a regular-file copy → the scratch home then
|
||
// FORKS the OAuth credentials. Because OAuth refresh tokens rotate (single-use), a
|
||
// refresh in the scratch home can invalidate the token the user's real-home claude
|
||
// relies on. Therefore scratch-home is safe only with a DEDICATED OAuth or for
|
||
// ephemeral use; for a shared subscription prefer real-home (tuiHome===realHome),
|
||
// which shares one .credentials.json — identical to how OCP already spawns claude.
|
||
// Idempotent + best-effort: any failure degrades toward the dialog/cap, never
|
||
// corrupts. Run BEFORE the session boots.
|
||
export function prepareTuiHome(realHome, tuiHome, cwd) {
|
||
if (!tuiHome || tuiHome === realHome) { ensureTuiCwdTrusted(realHome, cwd); return; }
|
||
try {
|
||
const claudeDir = `${tuiHome}/.claude`;
|
||
mkdirSync(`${claudeDir}/projects`, { recursive: true });
|
||
// Symlink the real credentials (never copy the OAuth token); refresh if missing.
|
||
const link = `${claudeDir}/.credentials.json`;
|
||
if (!existsSync(link)) {
|
||
try { symlinkSync(`${realHome}/.claude/.credentials.json`, link); } catch { /* best effort */ }
|
||
}
|
||
// Seed .claude.json ONCE (if absent): start from the onboarded real config,
|
||
// drop the user's project history, trust only the scratch cwd. mode 0600.
|
||
const seedPath = `${tuiHome}/.claude.json`;
|
||
if (!existsSync(seedPath)) {
|
||
let base = {};
|
||
try { base = JSON.parse(readFileSync(`${realHome}/.claude.json`, "utf8")); } catch { /* fresh */ }
|
||
base.hasCompletedOnboarding = true;
|
||
base.projects = { [cwd]: { hasTrustDialogAccepted: true, allowedTools: [] } };
|
||
writeFileSync(seedPath, JSON.stringify(base, null, 2), { mode: 0o600 });
|
||
}
|
||
} catch { /* best effort */ }
|
||
// Ensure the cwd is trusted in the scratch config (idempotent; atomic).
|
||
ensureTuiCwdTrusted(tuiHome, cwd);
|
||
}
|
||
|
||
// ── Billing-classifier labeling ─────────────────────────────────────────
|
||
// Resolve CLAUDE_CODE_ENTRYPOINT on the spawn env per mode. ALWAYS deletes any
|
||
// inherited value first (so a stray entrypoint from OCP's own parent env can never
|
||
// leak into / mislabel the billing header). Then:
|
||
// "cli" (default) → set "cli": deterministic subscription-pool classification.
|
||
// HONEST ONLY because OCP's spawn is a genuine interactive PTY (tmux pane,
|
||
// no -p, stdout not redirected). Never set "cli" on a non-interactive spawn.
|
||
// "auto" → leave unset → claude self-classifies via its t$A (TTY → cli). Use to
|
||
// observe/diagnose the real TTY-derived value.
|
||
// "off" → leave the env exactly as inherited (diagnostics / honesty audit).
|
||
export function resolveTuiEntrypointEnv(env, mode = "cli") {
|
||
if (mode === "off") return env;
|
||
delete env.CLAUDE_CODE_ENTRYPOINT;
|
||
if (mode === "cli") env.CLAUDE_CODE_ENTRYPOINT = "cli";
|
||
return env;
|
||
}
|
||
|
||
// Build interactive claude argv: NO -p, NO --output-format (=> cc_entrypoint=cli).
|
||
// MCP hard-disabled: --strict-mcp-config (no --mcp-config) is the only mechanism
|
||
// that stops account-attached managed MCP from connecting (spec §5.2 / T6),
|
||
// belt-and-braces with --disallowedTools "mcp__*".
|
||
// A-PATH ONLY: built-in tools are left enabled (acceptable single-user). Deployment B
|
||
// (guest keys) MUST additionally pass --tools "" per spec §5.2(2) as the credential
|
||
// wall before this argv is reachable for owner_tier=guest — guard that in PR-3 wiring.
|
||
export function buildTuiCmd(claudeBin, model, sessionId, ehome, entrypointMode) {
|
||
// Deliver claude's env via an `env` prefix on the PANE COMMAND — tmux does NOT forward the
|
||
// spawning process's environment to the pane, and `new-session -e` needs tmux ≥3.2 (the cloud
|
||
// host runs 2.7), so this is the only portable, reliable mechanism (verified live 2026-06-01:
|
||
// passing {env} to spawnSync left the pane with only HOME). DISABLE_AUTOUPDATER pins the version
|
||
// (no "What's new" splash that delayed input-readiness); CLAUDE_CODE_ENTRYPOINT labels the
|
||
// billing pool (set below per entrypointMode).
|
||
//
|
||
// CLAUDE_CODE_DISABLE_CLAUDE_MDS + DISABLE_AUTO_MEMORY: OCP is a PROXY, not a Claude Code
|
||
// session. The proxied client (OpenClaw / an IDE) owns its own context and memory; the HOST's
|
||
// CLAUDE.md and auto-memory must NEVER leak into the agent OCP runs on the user's behalf.
|
||
// Without these, claude loads the host's project/user CLAUDE.md + memory into every proxied
|
||
// turn — verified live 2026-06-02: a cwd CLAUDE.md ("end every reply with QUACKMARKER_42") was
|
||
// obeyed by the proxied turn until these flags were set, after which it was not. Unconditional
|
||
// by design (not gated): proxy purity is not an opt-in. Harmless on hosts with no CLAUDE.md
|
||
// (the common case — they suppress nothing). Mirrors the -p path's CLAUDE_NO_CONTEXT vars.
|
||
const sets = [
|
||
`HOME=${shq(ehome)}`,
|
||
"DISABLE_AUTOUPDATER=1",
|
||
"CLAUDE_CODE_DISABLE_OFFICIAL_MARKETPLACE_AUTOINSTALL=1",
|
||
"CLAUDE_CODE_DISABLE_CLAUDE_MDS=1",
|
||
"CLAUDE_CODE_DISABLE_AUTO_MEMORY=1",
|
||
];
|
||
const unset = ["CLAUDECODE", "ANTHROPIC_API_KEY", "ANTHROPIC_BASE_URL", "ANTHROPIC_AUTH_TOKEN"];
|
||
if (entrypointMode === "cli") sets.push("CLAUDE_CODE_ENTRYPOINT=cli");
|
||
else if (entrypointMode === "auto") unset.push("CLAUDE_CODE_ENTRYPOINT"); // let claude self-classify via TTY
|
||
const envPrefix = ["env", ...unset.map((u) => `-u ${u}`), ...sets].join(" ");
|
||
|
||
// Tool surface.
|
||
// DEFAULT (safe): hard-disable MCP (--strict-mcp-config + --disallowedTools mcp__*);
|
||
// built-in tools stay on, acceptable for single-user A-path.
|
||
// OCP_TUI_FULL_TOOLS=1: grant the SAME tool surface as the -p A-path
|
||
// (--allowedTools [+ --mcp-config] [+ --dangerously-skip-permissions]), so a
|
||
// SINGLE-USER / trusted TUI deployment can run a tool-using agent (e.g. an OpenClaw
|
||
// assistant that needs Bash/Read/Write/MCP) on the subscription pool. This mirrors
|
||
// buildCliArgs() in server.mjs. Safe to gate ON only because TUI is hard-incompatible
|
||
// with AUTH_MODE=multi (server.mjs refuses to boot), so it can never widen a guest's
|
||
// surface. Env mirrors server.mjs's CLAUDE_ALLOWED_TOOLS / _SKIP_PERMISSIONS / _MCP_CONFIG.
|
||
let toolArgs;
|
||
if (process.env.OCP_TUI_FULL_TOOLS === "1") {
|
||
toolArgs = [];
|
||
if (process.env.CLAUDE_SKIP_PERMISSIONS === "true") {
|
||
toolArgs.push("--dangerously-skip-permissions");
|
||
} else {
|
||
const allowed = (process.env.CLAUDE_ALLOWED_TOOLS ||
|
||
"Bash,Read,Write,Edit,Glob,Grep,WebSearch,WebFetch,Agent")
|
||
.split(",").map((s) => s.trim()).filter(Boolean);
|
||
// shq EACH token: buildTuiCmd returns a SHELL STRING (run by tmux via sh -c), unlike
|
||
// buildCliArgs which returns an argv array to spawn(). claude accepts scoped specifiers
|
||
// like "Bash(npm run test:*)" / "Read(~/**)" whose ( ) * ~ would break/inject the shell
|
||
// command if pasted bare. (operator-self-injection only — guests can't reach TUI.)
|
||
if (allowed.length) toolArgs.push("--allowedTools", ...allowed.map(shq));
|
||
}
|
||
if (process.env.CLAUDE_MCP_CONFIG) toolArgs.push("--mcp-config", shq(process.env.CLAUDE_MCP_CONFIG));
|
||
} else {
|
||
toolArgs = ["--strict-mcp-config", "--disallowedTools", shq("mcp__*")];
|
||
}
|
||
return [
|
||
envPrefix,
|
||
shq(claudeBin),
|
||
"--model", shq(model),
|
||
"--session-id", sessionId,
|
||
...toolArgs,
|
||
].join(" ");
|
||
}
|
||
|
||
// Full per-request TUI lifecycle:
|
||
// 1. Pre-trust the scratch cwd (no trust dialog will appear).
|
||
// 2. Write prompt to a 0600 temp file (no shell injection from prompt content).
|
||
// 3. Boot an interactive `claude` in a fresh tmux session in the scratch cwd; poll
|
||
// capture-pane until the `? for shortcuts` input bar appears (readiness-poll
|
||
// replaces the old blind boot sleep). BOOT_MS is the max wait, not a fixed delay.
|
||
// 4. Paste the prompt via tmux load-buffer + paste-buffer -p (bracketed paste) —
|
||
// reliable for large multi-line prompts where send-keys -l is not (issue #130).
|
||
// Poll-verify the prompt landed in the input (placeholder gone / [Pasted text]);
|
||
// fast-fail with tui_paste_not_landed if it never lands (prevents the 120s
|
||
// wallclock "stuck typing" hang). Then submit with a SEPARATE Enter key event.
|
||
// 5. Block on the native JSONL transcript (located by session-id) until terminal
|
||
// marker or wall-clock cap.
|
||
// 6. Always teardown: kill session + rm temp dir (even on throw).
|
||
// Returns { text, entrypoint } from readTuiTranscript (entrypoint is the billing-pool
|
||
// classifier, e.g. "cli", or null if the transcript did not include a turn_duration).
|
||
export async function runTuiTurn({
|
||
prompt,
|
||
model,
|
||
claudeBin,
|
||
home,
|
||
realHome,
|
||
cwd,
|
||
wallclockMs = 120000,
|
||
entrypointMode = "cli",
|
||
tmux = defaultTmux,
|
||
}) {
|
||
const sessionId = randomUUID();
|
||
const tmuxName = SESSION_PREFIX + sessionId.slice(0, 8);
|
||
const ehome = home || process.env.HOME; // HOME claude runs under (scratch or real)
|
||
const rhome = realHome || process.env.HOME; // real home (OAuth + onboarded config source)
|
||
|
||
// Ensure scratch cwd exists, then prepare the (scratch or real) HOME + trust the
|
||
// cwd — before claude boots.
|
||
if (!existsSync(cwd)) mkdirSync(cwd, { recursive: true });
|
||
prepareTuiHome(rhome, ehome, cwd);
|
||
|
||
// Write prompt to a temp file (mode 0600) so the content never touches argv.
|
||
const tmpDir = mkdtempSync(`${tmpdir()}/ocp-tui-`);
|
||
const promptFile = `${tmpDir}/prompt.txt`;
|
||
writeFileSync(promptFile, prompt, { mode: 0o600 });
|
||
|
||
// Build the env: disable marketplace auto-install, strip any Anthropic / CC
|
||
// env vars that might interfere with interactive-mode classification.
|
||
const env = { ...process.env, CLAUDE_CODE_DISABLE_OFFICIAL_MARKETPLACE_AUTOINSTALL: "1" };
|
||
delete env.CLAUDECODE;
|
||
delete env.ANTHROPIC_API_KEY;
|
||
delete env.ANTHROPIC_BASE_URL;
|
||
delete env.ANTHROPIC_AUTH_TOKEN;
|
||
env.HOME = ehome; // claude reads credentials + writes the transcript under this HOME
|
||
resolveTuiEntrypointEnv(env, entrypointMode);
|
||
|
||
try {
|
||
// 1. Boot the interactive session inside tmux, rooted at the scratch cwd.
|
||
// Capture the result: if tmux new-session fails (status !== 0) there is no
|
||
// PTY, no interactive spawn — abort BEFORE the boot sleep rather than paste
|
||
// into a non-existent session or issue a billing request without a verified
|
||
// interactive context. The finally teardown is still harmless (kill-session
|
||
// is a no-op when the session never existed).
|
||
const spawnResult = tmux(
|
||
["new-session", "-d", "-s", tmuxName, "-x", "220", "-y", "50", "-c", cwd,
|
||
buildTuiCmd(claudeBin, model, sessionId, ehome, entrypointMode)],
|
||
{ env },
|
||
);
|
||
if (!spawnResult || spawnResult.status !== 0) {
|
||
throw new Error("tui_spawn_failed: tmux session not created");
|
||
}
|
||
|
||
// 2. Wait until claude's input bar is actually ready (was: blind sleep(BOOT_MS)).
|
||
// BOOT_MS is now the MAX readiness wait, not a fixed delay.
|
||
const ready = await pollUntil(() => tuiInputReady(tuiCapturePane(tmux, tmuxName)),
|
||
{ timeoutMs: BOOT_MS, intervalMs: READY_POLL_MS });
|
||
if (!ready) {
|
||
// (readiness timed out; relying on paste-verify)
|
||
console.error("[tui] input_not_ready", tmuxName);
|
||
}
|
||
|
||
// 3. Paste the prompt via a tmux PASTE BUFFER with bracketed paste (-p), NOT
|
||
// `send-keys -l`. send-keys of a large multi-line prompt is unreliable: the
|
||
// embedded newlines arrive as separate key events (effectively repeated Enter),
|
||
// so a big OpenClaw-style prompt never lands and the turn hangs to the wallclock
|
||
// (issue #130 — reproduced at ~300 lines; fixed by bracketed paste). load-buffer
|
||
// reads the file directly (no shell arg limit, no `"$(cat)"`), and paste-buffer -p
|
||
// wraps it in bracketed-paste markers so claude ingests it atomically as ONE paste
|
||
// ("[Pasted text #N +M lines]"). -d deletes the buffer afterward. Buffer name is the
|
||
// per-session tmuxName, so concurrent turns never collide.
|
||
tmux(["load-buffer", "-b", tmuxName, promptFile]);
|
||
tmux(["paste-buffer", "-b", tmuxName, "-t", tmuxName, "-p", "-d"]);
|
||
|
||
// Verify the prompt POSITIVELY landed before submitting; poll (a large bracketed paste
|
||
// takes a beat to render the "[Pasted text]" indicator). This is load-bearing: firing
|
||
// Enter before the paste renders submits an empty box → the turn hangs to the wallclock
|
||
// (issue #130). Fast-fail if it never lands → deterministic error in seconds.
|
||
const landed = await pollUntil(() => tuiPromptLanded(tuiCapturePane(tmux, tmuxName), prompt),
|
||
{ timeoutMs: PASTE_VERIFY_MS, intervalMs: READY_POLL_MS });
|
||
if (!landed) {
|
||
throw new Error("tui_paste_not_landed: prompt did not reach claude's input within " + PASTE_VERIFY_MS + "ms");
|
||
}
|
||
|
||
// Submit (separate Enter key event).
|
||
tmux(["send-keys", "-t", tmuxName, "Enter"]);
|
||
|
||
// 4. Block on the native transcript (resolved by session-id) until terminal.
|
||
// Returns { text, entrypoint } from readTuiTranscript.
|
||
return await readTuiTranscript({ home: ehome, sessionId, wallclockMs });
|
||
} finally {
|
||
// 5. Teardown — always, even on throw.
|
||
try { tmux(["kill-session", "-t", tmuxName]); } catch { /* already gone */ }
|
||
try { rmSync(tmpDir, { recursive: true, force: true }); } catch { /* best effort */ }
|
||
}
|
||
}
|