mirror of
https://github.com/dtzp555-max/olp.git
synced 2026-07-21 21:15:10 +00:00
Phase 1 Day 1. First executable code lands. Zero providers wired yet
(per ALIGNMENT.md "v0.1 ships 0 Enabled Providers"); the server starts
clean and POST /v1/chat/completions returns 503 with no_enabled_provider.
Files added:
lib/ir/types.mjs - IR v1.0 schema + validators (ADR 0003)
lib/ir/openai-to-ir.mjs - OpenAI Chat Completions to IR
lib/ir/ir-to-openai.mjs - IR chunks to OpenAI SSE / non-stream
lib/providers/base.mjs - Provider contract + validateProvider + ProviderError
lib/providers/index.mjs - Static empty registry stub (ADR 0002)
server.mjs - HTTP listener with createOlpServer factory + main guard
test-features.mjs - 61 tests across 7 suites (IR / provider / HTTP)
Files modified:
package.json - main and scripts.start/test added back; targets now exist.
Authority citations:
IR fields and translation direction: ADR 0003 sections Decision and
Translation direction model.
Provider contract (9 fields): ADR 0002 section Provider contract v1.0
interface.
Entry surface routes (health, v1/models, v1/chat/completions): OLP v0.1
spec section 4.1 single-protocol entry; ALIGNMENT.md Authority 2.
Zero-Enabled-Providers behaviour: ALIGNMENT.md Provider Inventory.
Architectural decisions worth recording:
1. server.mjs uses a createOlpServer factory plus an import.meta.url
main guard. The factory returns an unbound http.Server; only the
main-script invocation calls .listen(). Tests import the real
server.mjs and exercise the real router. No parallel implementation
in the test file.
This pattern was a fold-in from the orchestration step. The initial
sonnet draft put a top-level server.listen call in server.mjs, which
forced test-features.mjs to reimplement the router inline (a false-
confidence trap because the real server logic would never be tested).
Refactored before reviewer dispatch.
2. lib/providers/index.mjs ships an empty STATIC_REGISTRY array, not a
placeholder with dummy entries. ALIGNMENT.md Provider Inventory says
v0.1 ships zero Enabled Providers; the registry honors that exactly.
Phase 1 Day 2 adds the first import (Anthropic) when its plugin lands.
3. BadRequestError lives in openai-to-ir.mjs and ProviderError in
base.mjs. Reviewer suggested relocating to a shared lib/errors.mjs
once the count exceeds two; deferred to Phase 1 Day 2 to ship with
the third typed error class.
4. contractVersion: '1.0' on each provider plugin: not enforced at D3
because no providers exist yet. Reviewer flagged for Phase 1 Day 2
tightening when the first provider lands.
Reviewer chain (Iron Rule 10):
Initial implementer: sonnet (general-purpose).
Refactor (createOlpServer + main guard) by the orchestrator after
catching the inline-router parallel-implementation issue.
Fresh-context reviewer: opus (ecc:code-reviewer). Verdict
APPROVE_WITH_MINOR.
Reviewer's two non-blocking findings folded in:
F1: removed unused createServer import from test-features.mjs line 12,
left over from the refactor.
F2: replaced finish_reason value 'error' with 'stop' in both the
streaming error chunk path (lib/ir/ir-to-openai.mjs line 72) and
the non-streaming error aggregation path (lib/ir/ir-to-openai.mjs
line 153). The 'error' value is not in OpenAI's documented
finish_reason enum (stop / length / tool_calls / content_filter /
function_call / null), so emitting it would violate ALIGNMENT.md
Rule 2 (b). Provider errors are now surfaced via a top-level
response.error object plus an inline content marker. The matching
test assertion at test-features.mjs line 325 was updated to verify
finish_reason stays within the OpenAI enum.
Note on the F2 fold-in:
Reviewer pointed only at the streaming path (line 72). After applying
that fix I ran grep across lib/ and test-features.mjs for the same
invention pattern and caught a second hit at line 153 (non-streaming
aggregation). This is the "fold-in must grep the full repo, not only
the file the reviewer named" discipline from
~/.cc-rules/memory/feedback/evidence_first_under_speed_pressure.md.
Both hits are fixed in this commit.
Verification:
node --check on all 7 new files plus modified package.json plus
server.mjs plus lib/ir/ir-to-openai.mjs - all clean.
npm test - 61/61 pass in 209ms, no flakes, no skipped.
OLP_PORT=14001 node server.mjs followed by curl /health returns
proper JSON; curl /v1/models returns 200 empty list; server shuts
down cleanly on signal.
grep "finish_reason.*error" returns zero hits across lib/ and tests.
Co-Authored-By: Claude Opus 4.7 (noreply@anthropic.com)
173 lines
5.8 KiB
JavaScript
173 lines
5.8 KiB
JavaScript
/**
|
|
* lib/ir/types.mjs — IR v1.0 type definitions and validators
|
|
*
|
|
* Authority: ADR 0003 § "Required fields" and "Optional fields"
|
|
* The IR is OLP-internal; there is no external IR endpoint.
|
|
* Per ADR 0003, the IR encodes the common subset that every provider
|
|
* plugin can consume, with lossy edges documented per-provider.
|
|
*/
|
|
|
|
// ── Constants ──────────────────────────────────────────────────────────────
|
|
|
|
export const IR_VERSION = '1.0';
|
|
|
|
/** Per ADR 0003 § Required fields. role='function' is OpenAI-deprecated; openai-to-ir.mjs maps it to 'tool'. */
|
|
export const VALID_ROLES = ['system', 'user', 'assistant', 'tool'];
|
|
|
|
// ── JSDoc typedefs ────────────────────────────────────────────────────────
|
|
|
|
/**
|
|
* @typedef {Object} IRToolCall
|
|
* @property {string} id
|
|
* @property {'function'} type
|
|
* @property {{ name: string, arguments: string }} function
|
|
*/
|
|
|
|
/**
|
|
* @typedef {Object} IRMessage
|
|
* @property {'system'|'user'|'assistant'|'tool'} role
|
|
* @property {string|Array<{type:string,[key:string]:any}>} content
|
|
* @property {string} [name]
|
|
* @property {IRToolCall[]} [tool_calls]
|
|
* @property {string} [tool_call_id]
|
|
*/
|
|
|
|
/**
|
|
* @typedef {Object} IRToolDefinition
|
|
* @property {'function'} type
|
|
* @property {{ name: string, description?: string, parameters?: object }} function
|
|
*/
|
|
|
|
/**
|
|
* @typedef {Object} IRRequest
|
|
* @property {string} irVersion - always IR_VERSION
|
|
* @property {IRMessage[]} messages
|
|
* @property {string} model
|
|
* @property {boolean} stream
|
|
* @property {number} [max_tokens]
|
|
* @property {number} [temperature]
|
|
* @property {number} [top_p]
|
|
* @property {string|string[]} [stop]
|
|
* @property {IRToolDefinition[]} [tools]
|
|
* @property {string|object} [tool_choice]
|
|
* @property {object} [response_format]
|
|
*/
|
|
|
|
/**
|
|
* @typedef {Object} IRResponseChunk
|
|
* @property {'delta'|'stop'|'error'} type
|
|
* @property {string} [content] - present when type==='delta'
|
|
* @property {string} [role] - present on first delta
|
|
* @property {IRToolCall[]} [tool_calls] - present when provider emits tool-use in stream
|
|
* @property {string} [finish_reason] - present when type==='stop'
|
|
* @property {string} [error] - present when type==='error'
|
|
* @property {Object} [usage]
|
|
* @property {number} [usage.prompt_tokens]
|
|
* @property {number} [usage.completion_tokens]
|
|
* @property {number} [usage.total_tokens]
|
|
*/
|
|
|
|
// ── Validators ────────────────────────────────────────────────────────────
|
|
|
|
/**
|
|
* @param {*} obj
|
|
* @returns {{ valid: boolean, errors: string[] }}
|
|
*/
|
|
export function validateIRMessage(obj) {
|
|
const errors = [];
|
|
if (obj === null || typeof obj !== 'object') {
|
|
errors.push('message must be an object');
|
|
return { valid: false, errors };
|
|
}
|
|
if (!VALID_ROLES.includes(obj.role)) {
|
|
errors.push(`role must be one of ${VALID_ROLES.join('|')}, got ${JSON.stringify(obj.role)}`);
|
|
}
|
|
if (obj.content === undefined || obj.content === null) {
|
|
errors.push('content is required');
|
|
} else if (typeof obj.content !== 'string' && !Array.isArray(obj.content)) {
|
|
errors.push('content must be a string or array of content parts');
|
|
}
|
|
if (obj.name !== undefined && typeof obj.name !== 'string') {
|
|
errors.push('name must be a string when present');
|
|
}
|
|
if (obj.tool_call_id !== undefined && typeof obj.tool_call_id !== 'string') {
|
|
errors.push('tool_call_id must be a string when present');
|
|
}
|
|
if (obj.tool_calls !== undefined) {
|
|
if (!Array.isArray(obj.tool_calls)) {
|
|
errors.push('tool_calls must be an array when present');
|
|
}
|
|
}
|
|
return { valid: errors.length === 0, errors };
|
|
}
|
|
|
|
/**
|
|
* @param {*} obj
|
|
* @returns {{ valid: boolean, errors: string[] }}
|
|
*/
|
|
export function validateIRRequest(obj) {
|
|
const errors = [];
|
|
if (obj === null || typeof obj !== 'object') {
|
|
errors.push('IR request must be an object');
|
|
return { valid: false, errors };
|
|
}
|
|
|
|
// Required: messages
|
|
if (!Array.isArray(obj.messages)) {
|
|
errors.push('messages must be an array');
|
|
} else {
|
|
obj.messages.forEach((m, i) => {
|
|
const r = validateIRMessage(m);
|
|
if (!r.valid) {
|
|
r.errors.forEach(e => errors.push(`messages[${i}]: ${e}`));
|
|
}
|
|
});
|
|
if (obj.messages.length === 0) {
|
|
errors.push('messages must not be empty');
|
|
}
|
|
}
|
|
|
|
// Required: model
|
|
if (typeof obj.model !== 'string' || obj.model.trim() === '') {
|
|
errors.push('model must be a non-empty string');
|
|
}
|
|
|
|
// Required: stream
|
|
if (typeof obj.stream !== 'boolean') {
|
|
errors.push('stream must be a boolean');
|
|
}
|
|
|
|
// Optional: max_tokens
|
|
if (obj.max_tokens !== undefined && (!Number.isInteger(obj.max_tokens) || obj.max_tokens <= 0)) {
|
|
errors.push('max_tokens must be a positive integer when present');
|
|
}
|
|
|
|
// Optional: temperature [0,2]
|
|
if (obj.temperature !== undefined) {
|
|
if (typeof obj.temperature !== 'number' || obj.temperature < 0 || obj.temperature > 2) {
|
|
errors.push('temperature must be a number in [0,2] when present');
|
|
}
|
|
}
|
|
|
|
// Optional: top_p [0,1]
|
|
if (obj.top_p !== undefined) {
|
|
if (typeof obj.top_p !== 'number' || obj.top_p < 0 || obj.top_p > 1) {
|
|
errors.push('top_p must be a number in [0,1] when present');
|
|
}
|
|
}
|
|
|
|
// Optional: stop
|
|
if (obj.stop !== undefined) {
|
|
if (typeof obj.stop !== 'string' && !Array.isArray(obj.stop)) {
|
|
errors.push('stop must be a string or array of strings when present');
|
|
}
|
|
}
|
|
|
|
// Optional: tools
|
|
if (obj.tools !== undefined && !Array.isArray(obj.tools)) {
|
|
errors.push('tools must be an array when present');
|
|
}
|
|
|
|
return { valid: errors.length === 0, errors };
|
|
}
|