Post-Phase-3 cleanup batch #1. Bundles two small v1.x-roadmap deferrals (#4 and #7 in docs/v1x-roadmap.md) into one D-day. No new user-facing feature; pins existing behaviour into tests + finally wires the ADR-documented activeSpawns field on /health. (1) AUTH_MISSING tuple test (v1.x #7, D45 P3 deferral) New engine-level test in Suite D40 asserts that an AUTH_MISSING hop produces a fallbackDetail tuple with trigger_type: 'auth_missing' AND that the engine does NOT advance past it (HARD_TRIGGER_CODES[AUTH_MISSING]=false). Pre-D56 the behaviour was implicit through neighbouring tests; D56 makes it explicit so a future refactor that moves the tuple-push past the auth_missing branch fails this test directly. Authority: ADR 0004 § Decision (hard-trigger table) + Amendment 5 (tuple shape). (2) /health activeSpawns integration (v1.x #4, ADR 0002 Amendment 6 forward note) handleHealth now surfaces providers.status.<name>.activeSpawns (sourced from D38 getActiveSpawnCount(name) — already imported at server.mjs:39). The field is computed BEFORE healthCheck() is awaited so it remains present even when healthCheck() throws — getActiveSpawnCount is a cheap in-memory counter read. New Suite 21c-extra test pins the field presence + numeric + non-negative for every enabled provider in the fixture. Authority: ADR 0002 Amendment 6 § "Forward note — exposing the counter via HTTP" — names the path providers.status.<name>.activeSpawns and pins it as the Phase 1 deferral that becomes due once management endpoints exist (which they now do, post-Phase-3). Test count: 601 → 603 (+2 D56 tests; 603/603 pass locally). Release-kit: under Unreleased per phase_rolling_mode (Phase 3 closed at v0.3.0; Phase 4 entries also land here once Phase 4 opens — D56 is a cleanup-D-day that ships under v0.3.x, not a Phase 4 deliverable). Co-authored-by: dtzp555 <dtzp555@gmail.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
94 KiB
Changelog
All notable changes to OLP land here. Per CLAUDE.md release_kit overlay, this file is the source of truth for GitHub release notes.
Unreleased
D56 — v1.x cleanup batch #1: AUTH_MISSING tuple test + /health activeSpawns (post-Phase-3)
Post-Phase-3 cleanup batch. Resolves two small v1.x-roadmap deferrals into one D-day. No new user-facing feature; pins existing behaviour into tests + finally wires the ADR-documented activeSpawns field on /health.
- AUTH_MISSING tuple test (v1.x roadmap #7 / D45 reviewer P3 deferral). New engine-level test in Suite D40 asserts that an
AUTH_MISSINGhop produces afallbackDetailtuple withtrigger_type: 'auth_missing'AND that the engine does NOT advance past the AUTH_MISSING hop (per ADR 0004 § Decision —HARD_TRIGGER_CODES[AUTH_MISSING]=false). Pre-D56 the behaviour was implicit through other engine-path tests; this commit makes it explicit so a future refactor that moves the tuple-push past the auth_missing branch fails this test directly. /healthactiveSpawns integration (v1.x roadmap #4 / ADR 0002 Amendment 6 forward note).handleHealthnow surfacesproviders.status.<name>.activeSpawns(sourced from D38getActiveSpawnCount(name)). The field is set BEFOREhealthCheck()is awaited so it remains accessible even whenhealthCheck()throws (cheap in-memory counter read). New Suite 21c-extra test pins the field presence + non-negative value for every enabled provider. With no requests in flight: 0; under saturation: equalshints.maxConcurrent.- Test count: 601 → 603 (+2 D56 tests).
- Authority:
docs/v1x-roadmap.md#4 + #7; ADR 0002 Amendment 6 (concurrency observability forward note); ADR 0004 Amendment 5 (X-OLP-Fallback-Detail tuple shape the new test asserts).
v0.3.0 — 2026-05-25
Phase 3 — Dashboard + audit query layer + daily audit rotation (D48 → D54)
Overview. v0.3.0 closes Phase 3 — the dashboard / audit aggregate query / daily rotation track that grew OLP from "audit ndjson exists but is grep-only" (v0.2.0) to a live multi-panel owner-only dashboard with aggregate queries + automatic daily file rotation. 7 D-day commits (D48 through D54) shipped between 2026-05-25 under the standing-autopilot grant. All 15 ADR 0008 § 10 acceptance criteria are implemented + tested.
Test count: 544 (v0.2.0) → 601 (v0.3.0). +57 tests across the Phase 3 arc.
Phase 3 release_kit checklist
- All 7 D-day deliverables landed on main (D48 ADR + D49-D54 implementation)
- CI green on every D-day merge commit + on this release commit's head
- Fresh-context opus reviewer on every implementation D-day (D49/D50/D51/D52/D53) + D48 ADR draft + D54 docs polish
- All 15 ADR 0008 § 10 acceptance criteria (#1–#15) covered by Suite 23/24/25/26/20h-extra-audit tests
- CHANGELOG "Unreleased" promoted to "## v0.3.0 — 2026-05-25" with D48 through D54 entries
package.jsonbumped 0.2.0 → 0.3.0CLAUDE.md release_kit.phase_rolling_mode:current_phasePhase 3 → Phase 4;current_pre_release_identifier0.3.0-phase3→0.4.0-phase4- README status header + Implementation Status + Phase plan reflect Phase 3 shipped
- Tag pushed (next step in this PR's lifecycle)
release.ymltriggered + GitHub Release created (auto on tag push; D37 phase_rolling_mode gate will pass because Unreleased is now sentinel-only)
ADR 0008 § 10 acceptance criteria — final ship status
| # | Criterion | Covering tests |
|---|---|---|
| 1 | readAuditWindow iterates events from today + N prior rotated files |
Suite 23b-1, 23b-2, 23b-3 |
| 2 | readAuditWindow skips malformed lines without throwing + logs warn |
Suite 23b-6 |
| 3 | aggregateRequests counts by provider / cache_status / owner_tier / path + median/p95 latency |
Suite 23c-1, 23c-2, 23c-3 |
| 4 | topFallbackChains sort desc by count + tied-count tiebreak |
Suite 23d-1, 23d-4 |
| 5 | spendTrendDaily sparse-fills zero-request days + UTC day boundaries |
Suite 23e-1, 23e-2, 23e-3 |
| 6 | Daily rotation past UTC midnight | Suite 26a-3, 26b-1 |
| 7 | Cross-file query with mixed rotated files | Suite 26e-1 + Suite 23b-1 |
| 8 | Concurrent rotation safety (N appends → 1 rename) | Suite 26c-1 |
| 9 | GET /dashboard 200 to owner; 401 to non-owner |
Suite 24a, 24b, 24c, 24d |
| 10 | GET /v0/management/dashboard-data 200 to owner with all required fields |
Suite 24e |
| 11 | GET /cache/stats 200 to owner with live stats |
Suite 24h |
| 12 | Dashboard HTML smoke (4 panel containers + 30s poll + no external resources) | Suite 25a-25f |
| 13 | Audit row on management endpoints (success + 401) | Suite 24i, 24j |
| 14 | Graceful degradation on quotaStatus() throw (panel surfaces null + error) |
server.mjs handleManagementDashboardData try/catch verified by code |
| 15 | PII guard — no message-content fields in any aggregate output | Suite 23g-1, 23g-2, 23g-3 |
Phase 3 D-day index
- D48 (
c0b6969) — ADR 0008 Phase 3 design draft (Dashboard + audit query layer) + lane decisions A/A/B/A/B - D49 (
686794e) —lib/audit-query.mjsaggregate query layer (5 functions, PII-guarded) - D50 (
f9f2eaa) —server.mjs4 management endpoints (owner_only_block per ADR 0008 § 8) + dashboard.html placeholder - D51 (
251b578) —dashboard.htmlfull multi-panel UI (vanilla HTML+JS+fetch, 30s poll with visibilitychange pause) - D52 (
408d5a8) — Daily audit rotation inlib/audit.mjs(synchronous trigger on first append after UTC midnight) +bin/olp-audit-rotate.mjsexternal cron tool - D53 (
68e50da) —tried_providersschema semantic fix (D45 P2 deferral closed; ADR 0007 § 8 amendment) - D54 (
6d9ab1f) — README Phase 3 polish (docs-only)
Bonus: also resolved at D53 — D45 fresh-context opus reviewer P2 deferral (tried_providers semantics on key_no_provider_access 403). ADR 0007 § 8 amended; server.mjs sets tried_providers = [] on the 403 path so downstream audit queries stay accurate.
Known limitations carried beyond v0.3.0
Phase 3 functional scope is complete. The following remain as Phase 4+ deferrals (tracked in docs/v1x-roadmap.md + the new Phase 4 entry below):
- Per-key per-provider auth artifact mapping — ADR 0007 § 12. Each OLP key independently authenticated to a different provider account.
- Audit query rotation / retention policies — ADR 0008 § 11. Currently unbounded; operator manages disk. A Phase 4+ amendment adds
audit_max_daysconfig when an operational need emerges. - SQLite hybrid migration — ADR 0007 § 13. Trigger: query latency > 2s on typical owner session OR > 5 owners polling. Requires engines bump + CI matrix change as a separate prior PR.
- Provider-cost weights for spend trend — ADR 0008 § 11. At v0.3.0 "spend" is proxied by request count; cost integration when commercial cost-tracking lands.
- Per-key dashboard views — owner sees aggregate; per-key drill-down is a future amendment.
- Key-mgmt UI on dashboard — owner can create / revoke / edit keys from web. Out of Phase 3 scope; needs separate security review per ADR 0008 § 11.
- Manual smoke for dashboard — per ADR 0008 § 10 #12 the "no JS console errors in real browser" sub-claim is manual / playwright; Phase 3 acceptance shipped with server-observable checks (Suite 25); a Phase 4+ amendment may add playwright smoke if dashboard complexity grows.
D54 — README Phase 3 polish (docs-only, no code change)
Seventh Phase 3 D-day. Documentation polish ahead of Phase 3 close (D55, maintainer-triggered). Brings README status header / Implementation Status / API Endpoints / Known limitations / Phase plan up to date with Phase 3 work shipped to main through D48-D53.
- Status header:
v0.2.0 shipped→v0.2.0 shipped; v0.3.0 in progress+ lists D48-D54 highlights. - Implementation status note: Phase 3 description updated from "next milestone" to "shipped to main through D54; v0.3.0 release pending maintainer-triggered close (D55)".
- Implementation Status table — 4 row updates:
lib/audit.mjs: 🟡 D45-only → ✅ D45 append + D52 rotation; describes both responsibilities.lib/audit-query.mjs: NEW row (D49 shipped, 5-function aggregate query API).dashboard.html: 📋 Planned (Phase 6) → ✅ Phase 3 shipped (D50 stub + D51 full UI); describes the 4 panels.bin/olp-audit-rotate.mjs: NEW row (D52 shipped, external cron tool).
- API Endpoints table —
/cache/stats,/v0/management/quota,/dashboard(Phase 6 📋 Planned → Phase 3 ✅ Shipped); new/v0/management/dashboard-datarow;/healthrow clarified to spell out owner-only-trim semantic. Removed the "placeholder — full table lands" stub since the table is now substantively complete. - Known limitations — Phase 2 paragraph kept (now reads as historical Phase 2 completion note); new Phase 3 paragraph summarizing D48-D54 shipped + D55 close pending.
- Phase plan — Phase 3 description (was "next") → "🟡 In progress — D48 (ADR) + D49–D54 shipped to main 2026-05-25; v0.3.0 close awaits maintainer trigger." Added Phase 4+ entry covering the deferred items (per-key per-provider auth, SQLite hybrid, audit rotation/retention policies, provider-cost weights).
- Test count: 601 → 601 (docs-only).
- Authority: CLAUDE.md
release_kit overlay phase_rolling_mode— under Unreleased; ADR 0008 § 13 sprint shape (D54 = "E2E + AGENTS / README polish"); standing autopilot grant.
D53 — tried_providers schema semantic fix (D45 P2 deferral closed)
Sixth Phase 3 D-day. Small focused fix for the D45 fresh-context opus reviewer P2 finding that was deferred: auditCtx.tried_providers on the key_no_provider_access 403 path was being stamped with the ORIGINAL chain (which was filtered out, never dispatched), distorting downstream audit queries like "which providers did key X actually call".
server.mjs403 path fix (around L815):auditCtx.tried_providers = [](was_originalChainProviders). The configured-but-blocked chain still appears in the human-readable error message body — the audit just doesn't claim those providers were "tried" when the server's filter dispatched zero.- ADR 0007 § 8 amendment: new paragraph spelling out the
tried_providerssemantic — "the list of providers the server actually dispatched a spawn against. A provider that was configured in the chain but filtered out byproviders_enabledgating is NOT included — the key didn't try the provider, the gate did. On the 403 pathtried_providersis the empty array." Plus a forward note that audit log rotation moved to Phase 3 / ADR 0008 § 5. - Suite 20h-extra-audit (+1 test — 600 → 601): creates a guest key with
providers_enabled: ['mistral']; fires a request for an Anthropic-routed model; asserts 403key_no_provider_access; reads the audit row fromaudit.ndjson; assertstried_providers === []. This pins the D53 semantic against regression — if a future change reverts to stamping the original chain, the test fails. - Documentation: CHANGELOG D53 entry; ADR 0007 § 8 amendment.
- Test count: 600 → 601 (+1 D53 regression test).
- Authority: ADR 0007 § 8 amendment (D53, 2026-05-25); D45 fresh-context opus reviewer P2 deferral note; CLAUDE.md
release_kit overlay phase_rolling_mode— under Unreleased; standing autopilot grant.
D52 — Daily audit rotation (lib/audit.mjs extension + bin/olp-audit-rotate.mjs)
Fifth Phase 3 D-day. Adds daily UTC-aware rotation to lib/audit.mjs per ADR 0008 § 5 + ships an external cron tool. Rotation is synchronous at v0.3.0 (Lane 3 = B daily rotation; synchronous design eliminates the race that an async wrapper would create between date-change-detection and the append).
lib/audit.mjsextended:- New
_maybeRotateAudit({ olpHome, logEvent })(synchronous): probes the liveaudit.ndjson; if it holds events from a past UTC date, renames it toaudit-YYYY-MM-DD.ndjson. Idempotent. If the target file already exists (cron beat the in-server check), logs warn + skips per ADR 0008 § 5.3 race safety. appendAuditEventextended: cheap fast-path date check via module-cached_lastSeenUtcDate. On date change, calls_maybeRotateAuditsynchronously BEFOREappendFileSync— so old-date events land in the rotated file and new-date events land in the fresh live file. No event straddles the boundary.- Why synchronous instead of async: an async wrapper would let the sync
appendFileSyncrace the not-yet-completedrenameSync, landing today's event in the about-to-be-renamed file. Sync rotation is the only correct ordering at the append-fired-from-many-routes scale OLP runs. - New exports:
_maybeRotateAudit(sync),getAuditRotateCount,getAuditRotateFailCount,__resetAuditRotateState,__setLastSeenUtcDateForTesting. - First-event-date discovery: when probing the live file's date, reads only the first ndjson line + parses its
ts. Falls back to file mtime if events absent (corrupt/empty edge).
- New
bin/olp-audit-rotate.mjs(~95 lines): external cron tool per ADR 0008 § 5.2. Calls_maybeRotateAuditonce + reports outcome. Exit codes 0 (success or no-op), 1 (bad usage), 2 (rotation failed). Installed viapackage.json binsonpx olp-audit-rotate [--olp-home=<path>]works. Example cron line documented in the file header.- Concurrent-safety semantics (ADR 0008 § 5.3): in-process sequential appends after the first date-change detection short-circuit via the updated
_lastSeenUtcDatecache → exactly 1 rename even under N sequential appends. Cross-process (cron + server) coexistence handled by the "target already exists → skip + warn" branch. - Test surface (Suite 26, +12 tests — 588 → 600):
- 26a-1..5:
_maybeRotateAudit(no live file / today already / yesterday→rotate / idempotent re-call / cron-race target-exists warn) - 26b-1:
appendAuditEventpast UTC date change triggers sync rotation + append lands in fresh live file - 26c-1: 10 sequential
appendAuditEventacross date change → exactly 1 rotation + all 10 events in new live file - 26d-1..4:
bin/olp-audit-rotate.mjsCLI (--help / no-live-file / yesterday-file-rotates / unknown-flag exit 1) - 26e-1: rotated files queryable via
lib/audit-query.mjsdiscoverAuditFiles+readAuditWindowcross-file read
- 26a-1..5:
package.json:bin.olp-audit-rotate+scripts.olp-audit-rotateentries added.- Documentation: AGENTS.md
lib/audit.mjsmarker promoted to ✅ (D45 append + D52 rotation both shipped); newbin/olp-audit-rotate.mjsentry. - Test count: 588 → 600 (+12 D52 tests in Suite 26).
- Authority: ADR 0008 § 5.1 (first-append-after-UTC-midnight trigger), § 5.2 (external cron alternative), § 5.3 (concurrent-rotation safety + cron-coexistence semantics), § 5.4 (renamed-file query path consumed by D49 lib/audit-query.mjs); CLAUDE.md
release_kit overlay phase_rolling_mode— under Unreleased; standing autopilot grant.
D51 — dashboard.html full multi-panel UI (Phase 3)
Fourth Phase 3 D-day. Replaces the D50 dashboard.html placeholder with the full 4-panel UI per ADR 0008 § 6. Vanilla HTML + JS + fetch — no build step, no framework, no CDN (Lane 1 = A). 30s page poll with document.visibilityState pause/resume (Lane 4 = A).
- 4 panels rendered from
/v0/management/dashboard-data(the single backing endpoint, per Lane 2 in-memory query model):- Panel 1 — Per-provider quota: table of
{ Provider | Available | Status }; surfacesnullavailable as "n/a" + capturing per-providerprovider.quotaStatus()errors as a red status pill (graceful degradation per ADR § 9). - Panel 2 — Last 24h: request count + cache hit + fallback rate: per-provider row of
{ Requests | Cache hit % | Fallback rate % }. Cache hit sourced fromcache_hit_24h.by_provider[p].hit_rate; fallback rate computed fromwindow_24h.by_provider[p].fallback_count / count. - Panel 3 — Request count last 30 days (SVG sparkline): vanilla SVG bar chart with
<title>tooltips showing per-day per-provider breakdown. Y-axis: requests per day (scaled to max); X-axis: 30 daily buckets (UTC). Each bar<title>includes the date + total count + provider breakdown. - Panel 4 — Top fallback chains (last 24h): numbered table of
{ # | Chain | Count | First seen | Last seen }with chain arrows rendered in monospace (anthropic → openai).
- Panel 1 — Per-provider quota: table of
- 30s poll + visibilitychange pause (ADR 0008 § 6.5):
setInterval(refresh, 30000)after the initial fetch.document.addEventListener('visibilitychange', ...)→stopPolling()on hidden /refresh() + startPolling()on visible.- Per ADR § 6.5 this prevents 2880 background polls/day per owner when the dashboard tab is in the background.
- Error handling:
- 401 from
/v0/management/dashboard-data→ in-page error banner explains owner-tier requirement + suggests SSH-tunnel + header-injection workaround (browsers can't natively sendAuthorization: Bearerwithout a proxy/extension). - Other HTTP errors → generic "HTTP
" banner; console.warn for operator debugging. - Per-panel "Loading…" / "No requests in window." / "No fallback chains triggered" empty states.
- 401 from
- DOM helpers: small
el(tag, attrs, ...children)+svgEl(tag, attrs)factories — no framework, ~10 lines each. Sparkline uses native<title>for tooltips (no JS hover handlers). - Critical correctness invariants (per ADR 0008 § 6 + Lane 1 = A):
- No
<script src>— entire JS inline in<script>tag (Suite 25d asserts). - No
<link rel="stylesheet" href=>— all CSS in<style>tag (Suite 25d asserts). - Only one backing endpoint hit:
/v0/management/dashboard-data(Suite 25e asserts). All 4 panels consume slices of its response. - 401 path keeps panels in last-good state rather than clearing them; operator sees the error banner + can debug.
- No
- Test surface (Suite 25, +6 tests — 582 → 588):
- 25a: owner /dashboard response contains all 4 panel container IDs (
panel-quota,panel-24h,panel-trend,panel-chains). - 25b: dashboard JS declares
POLL_INTERVAL_MS = 30000+ usessetInterval+clearInterval. - 25c: visibilitychange listener wired + checks
document.visibilityState === 'hidden'. - 25d: NO external
<script src>and NO external stylesheet<link href>— pinning Lane 1 = A. - 25e: dashboard JS fetches
/v0/management/dashboard-data(the single consolidated D50 endpoint). - 25f: 401 in-page error banner mentions owner-tier so a maintainer who lands on a 401 knows the route forward.
- 25a: owner /dashboard response contains all 4 panel container IDs (
- Manual smoke (ADR 0008 § 10 #12 manual acceptance): the dashboard renders without console errors in a real browser when served by a running OLP instance + owner-tier Bearer token injected via SSH-tunnel + header-injection extension. Not automated at Phase 3 (Lane 4 = A poll model doesn't need playwright; Phase 4+ may add a playwright smoke if dashboard complexity grows).
- Documentation: AGENTS.md
dashboard.htmlmarker promoted from 🟡 D50 placeholder to ✅ D51 full UI. - Test count: 582 → 588 (+6 D51 tests in Suite 25).
- Authority: ADR 0008 § 6 (panels + refresh + localhost) + § 6.5 (poll + visibilityState pause) + Lane 1 = A (no build step) + Lane 4 = A (30s poll) + Lane 5 = B (full 4-panel scope); ADR § 9 (graceful degradation surfaced in Panel 1); ADR § 10 criterion #12 (HTML smoke); CLAUDE.md
release_kit overlay phase_rolling_mode— under Unreleased; standing autopilot grant.
D50 — server.mjs management endpoints (Phase 3 dashboard wire-up)
Third Phase 3 D-day. Wires the D49 lib/audit-query.mjs aggregate query layer into 4 owner_only_block HTTP endpoints per ADR 0008 §§ 7-8. Ships a placeholder dashboard.html at repo root (D51 lands the full multi-panel UI). All endpoints follow the Phase 2 / D45 auth + audit + touchLastUsed pattern.
- 4 new endpoints (all owner_only_block per ADR 0008 § 8 — anonymous + guest + missing-key all → 401):
GET /dashboard — serves dashboard.html (Content-Type text/html; charset=utf-8). D50 stub explains the state + lists backing endpoints; D51 replaces with full UI.
GET /v0/management/dashboard-data — full aggregate per ADR 0008 § 7.2: { generated_at, window_24h (auditAggregateRequests), cache_hit_24h (auditCacheHitRateWindow), quota (per-provider provider.quotaStatus + error capture), spend_trend_30d (auditSpendTrendDaily — exactly 30 entries), top_fallback_chains_24h (auditTopFallbackChains limit 10), cache_stats (live cacheStore.stats()) }.
GET /v0/management/quota — quota subset only (subset of dashboard-data; useful for scripted monitoring).
GET /cache/stats — live in-memory cacheStore.stats() shape ({ hits, misses, size, inflightCount } + generated_at wrapper).
_runOwnerOnlyManagementEndpoint(req, res, method, path, inner) helper factors the common auth + audit ctx + owner-block + res.on('finish') wire. inner is async (req, res, olpIdentity, auditCtx) → returns void. Eliminates 4× boilerplate.
owner_only_block mode (ADR 0008 § 8): authenticate → if not owner → 401 owner_required. Distinct from owner_only_trim (Phase 2 /health pattern). Anonymous identity (when allow_anonymous: true) reaches the handler and is 401'd by the owner check — verified by Suite 24c.
- Provider quotaStatus error capture: dashboard-data + quota endpoints catch per-provider throws and surface
{ provider, error, available: null } so one bad provider doesn't fail the whole panel (ADR 0008 § 9 graceful degradation).
dashboard.html placeholder (~50 lines at repo root): explains the D50 state, lists backing endpoints with curl example. Cached in memory at first /dashboard request (_loadDashboardHtml with module-scope _dashboardHtmlCache); falls back to an in-memory stub if the file is missing (e.g., test imports from non-repo cwd).
- Audit on management endpoints (ADR 0008 § 7.5): every management request appends an audit row including 401 paths (verified by Suite 24j). Touch wire skips anonymous + env-owner identities (matches Phase 2 pattern).
- Router: 4 new GET branches added between /v1/chat/completions and the 404 fallback.
- Test surface (Suite 24, +11 tests — 571 → 582):
- 24a-d: /dashboard owner_only_block (owner 200 / guest 401 / anonymous-with-allow_anonymous=true 401 / no-auth-with-allow_anonymous=false 401)
- 24e: dashboard-data owner → 200 JSON with all required ADR § 7.2 fields (asserts
spend_trend_30d.length === 30)
- 24f: dashboard-data guest → 401 owner_required
- 24g: quota owner → 200 JSON with quota array
- 24h: cache/stats owner → 200 JSON with
{ hits, misses, size, inflightCount, generated_at }
- 24h-401: cache/stats guest → 401
- 24i: successful dashboard-data appends audit row with
status_code: 200 + key_id + path: '/v0/management/dashboard-data'
- 24j: 401 (guest blocked) dashboard-data appends audit row with
error_code: 'owner_required' + owner_tier: 'guest'
- Documentation: AGENTS.md
lib/audit-query.mjs D49 marker note added + new dashboard.html entry (D50 placeholder).
- Test count: 571 → 582 (+11 D50 tests in Suite 24).
- Authority: ADR 0008 § 7 (endpoints) + § 8 (owner_only_block mode) + § 9 (graceful degradation) + § 7.5 (audit on management endpoints); ADR 0007 § 7 (auth model reused); ADR 0002 § Provider contract (quotaStatus); ADR 0005 (cacheStore.stats); CLAUDE.md
release_kit overlay phase_rolling_mode — under Unreleased; standing autopilot grant.
D49 — lib/audit-query.mjs audit aggregate query layer (Phase 3)
Second Phase 3 D-day. Implements ADR 0008 § 4 query API. Pure in-memory ndjson scan; cross-file walk over audit.ndjson (live) + audit-YYYY-MM-DD.ndjson (rotated). No server.mjs integration in this D-day (D50 wires the consuming endpoints).
- New file
lib/audit-query.mjs (~370 lines): 5 public API functions per ADR 0008 § 4.1:
discoverAuditFiles({ olpHome }) — filesystem scan; returns Map<date|'live', path>.
readAuditWindow({ startMs, endMs, olpHome, logEvent }) — generator over events in half-open window [startMs, endMs). Walks rotated date files + live file. Skips malformed lines + logs warn.
aggregateRequests({ windowMs, olpHome }) — counts + status buckets + by_provider + by_owner_tier + by_path + median/p95 latency over rolling window.
topFallbackChains({ windowMs, limit, olpHome }) — top-N chains by trigger count from events with fallback_hops > 0. Tied-count tiebreak: ascending first_seen.
spendTrendDaily({ days, olpHome }) — daily series ending today with sparse-fill for zero-request days. Per-day request_count + median latency + by_provider breakdown.
cacheHitRateWindow({ windowMs, olpHome }) — audit-derived cache hit rate (bypass excluded from denominator); per-provider + overall.
- PII discipline (ADR 0008 § 4.3): every aggregate function relays only schema fields; never message content. Suite 23g actively asserts the absence of
content/message/messages/prompt/response/body keys in every aggregate output.
- Cross-file walk semantics (ADR 0008 § 4.2): half-open window [startMs, endMs); date-range computed once from window bounds; each rotated date file checked; live
audit.ndjson always checked (it covers today regardless of whether the window endpoint is past midnight).
spendTrendDaily calendar-date semantics: days: N returns "last N calendar UTC dates ending today" — NOT "events within a rolling N×86400-ms window" (which would span N+1 distinct UTC dates and produce off-by-one buckets at non-midnight call times). Computed via for (let i = days-1; i >= 0; i--) dates.push(_utcDateFromMs(now - i*86400*1000));.
cacheHitRateWindow denominator: hit_rate = hit / (hit + miss). Bypass is intentional non-cacheable (Anthropic cache_control marker), NOT a cache miss; excluding it from the denominator gives a clean cache-effectiveness signal.
- Test surface (Suite 23, +27 tests — 544 → 571):
- 23a-1..4:
discoverAuditFiles (empty dir / live only / live+rotated / non-audit files ignored)
- 23b-1..6:
readAuditWindow (all-coverage / single-day / half-open exclusivity / empty window / missing files / malformed-skip with warn)
- 23c-1..4:
aggregateRequests (counts + status buckets + by_provider; by_owner_tier; median+p95 latency over realistic distribution; invalid windowMs rejection)
- 23d-1..4:
topFallbackChains (sort desc by count; limit truncation; fallback_hops=0 excluded; first_seen/last_seen carried)
- 23e-1..3:
spendTrendDaily (N-day range correctness; populated day breakdown; empty day sparse-fill)
- 23f-1..3:
cacheHitRateWindow (overall + per-provider hit_rate; bypass not in denominator; cache_status=null events excluded)
- 23g-1..3: PII guard for
aggregateRequests / spendTrendDaily / topFallbackChains + cacheHitRateWindow — every output JSON-stringified + scanned for forbidden PII keys
- Documentation: AGENTS.md
lib/audit-query.mjs new entry; lib/audit.mjs note added that D52 extends with daily rotation.
- Test count: 544 → 571 (+27 D49 tests).
- Authority: ADR 0008 § 4 (query API surface) + § 5 (rotation file naming pattern) + § 3 (storage layout); ADR 0007 § 8 (audit ndjson event schema — input data); CLAUDE.md
release_kit overlay phase_rolling_mode — under Unreleased; standing autopilot grant.
D48 — ADR 0008 Phase 3 design draft (Dashboard + audit query layer)
First Phase 3 D-day. Design-only. Ratifies the storage / query model / rotation / dashboard / refresh / scope decisions ahead of D49+ implementation D-days. Opens ADR 0007 § 12 deferral for Dashboard + audit query layer + rotation.
- New file
docs/adr/0008-dashboard-and-audit-query.md (~390 lines): 13 sections + Consequences + Authority citations. Decisions per maintainer-pinned lanes:
- Lane 1 (tech stack): static HTML + vanilla JS + fetch (no build step; matches OLP "no bundler" ethos)
- Lane 2 (query model): in-memory scan of audit ndjson per request (defers SQLite hybrid per ADR 0007 § 13)
- Lane 3 (rotation): daily rotation,
audit-YYYY-MM-DD.ndjson on first append after UTC midnight + optional bin/olp-audit-rotate.mjs external cron
- Lane 4 (refresh): 30s page poll (no SSE infra at v0.3.0)
- Lane 5 (dashboard scope): full per spec § 4.6 — 4 panels (quota / per-provider 24h counts / 30d spend trend / top fallback chains)
docs/adr/README.md index: added ADR 0008 row with one-paragraph summary.
- CHANGELOG.md Unreleased: this entry.
- Phase 3 sprint shape: D49
lib/audit-query.mjs + Suite 23 → D50 /v0/management/* endpoints + Suite 24 → D51 dashboard.html → D52 daily audit rotation + Suite 25 → D53 tried_providers schema fix (D45 P2 deferral) → D54 E2E + docs → D55 Phase 3 close → v0.3.0 (maintainer-triggered).
- Fold-in (fresh-context opus reviewer findings — 1 P2 + 2 P3, all ADR-text polish):
- P2 § 8 + § 10 #9 gating-mode wording — original § 8 implied a new "block non-owner identities" behaviour without naming it; § 10 #9 tested only the universal
allow_anonymous: false 401 case. Fix: § 8 now formalizes two gating modes — owner_only_trim (Phase 2 /health pattern) vs owner_only_block (new Phase 3 management-endpoints pattern) — and explains the management endpoints are owner_only_block because the entire payload is sensitive. § 10 #9 now covers both 401 paths (with allow_anonymous: true + no header → anonymous identity → still 401 because management endpoints are owner_only_block; AND with allow_anonymous: false + no header → 401 at the authenticate middleware itself).
- P3
/cache/stats citation accuracy — original § 7.4 + Authority block cited "ADR 0005 § Cache stats" which is not a real section. Corrected: planning authority is OLP v0.1 spec § 4.6; ADR 0005 references the endpoint in Consequences/Mitigations (~line 279) for the per-(provider, model) cache-hit-rate breakdown surface.
- P3
cacheStore.stats() shape gap — § 7.4 now explicitly acknowledges the current shape ({ hits, misses, size, inflightCount } global aggregate) lacks the per-(provider, model) breakdown spec § 4.6 implies; Phase 3 Panel 2 sources per-provider counts from aggregateRequests (audit-side) instead. If a future panel needs the breakdown, D50 amends the store shape + an ADR 0005 amendment fires at that time. Phase 3 acceptance criteria do not require the breakdown.
- Test count: 544 → 544 (design-only, no test change).
- Authority: ADR 0007 § 12 (opens deferral) + § 13 (rejects SQLite at Phase 3 per Node baseline); v0.1 spec § 4.6 / § 4.7 (Dashboard + observability endpoints planning authority); OCP
dashboard.html (prior art); CC 开发铁律 v1.6 § 10 — fresh-context opus reviewer required for design ADR; Phase 3 kickoff via maintainer "go" 2026-05-25 + standing-autopilot grant; PR #25 fresh-context opus reviewer findings (3 polish items).
v0.2.0 — 2026-05-25
Phase 2 — Multi-key auth + audit + owner gating + keygen CLI (D43-A → D47)
Overview. v0.2.0 closes Phase 2 — the multi-key authentication track that grew OLP from single-tenant anonymous-only proxy (v0.1.1) to a multi-identity deployment with per-key cache isolation, audit attribution, owner-vs-guest header gating, and a reproducible bootstrap CLI. 6 D-day commits (D43-A through D47) shipped between 2026-05-25 (single intensive session under the standing-autopilot grant). All 11 ADR 0007 § 10 acceptance criteria are implemented + tested.
Test count: 468 (v0.1.1) → 544 (v0.2.0). +76 tests across the Phase 2 arc.
Phase 2 release_kit checklist
- All 6 D-day deliverables landed on main (D43-A, D43-B ADR draft, D44, D45, D46, D47)
- CI green on every D-day merge commit + on this release commit's head
- Fresh-context opus reviewer on every implementation D-day (D44/D45/D46/D47), maintainer text-review on D43-B ADR
- All 11 ADR 0007 § 10 acceptance criteria (#1–#11) covered by Suite 19/20/21/22 tests
- CHANGELOG "Unreleased" promoted to "## v0.2.0 — 2026-05-25" with D43-A through D47 entries
package.json bumped 0.1.1 → 0.2.0
CLAUDE.md release_kit.phase_rolling_mode: current_phase Phase 2 → Phase 3; current_pre_release_identifier 0.2.0-phase2 → 0.3.0-phase3
- README status header + Implementation Status + Phase plan reflect Phase 2 shipped
- Tag pushed (next step in this PR's lifecycle)
release.yml triggered + GitHub Release created (auto on tag push; D37 phase_rolling_mode gate will pass because Unreleased is now sentinel-only)
ADR 0007 § 10 acceptance criteria — final ship status
#
Criterion
Covering tests
1
Per-key cache namespace isolation
Suite 20i
2
Anonymous prod-default off → 401
Suite 20a
3
Anonymous dev-mode on → 200
Suite 20g
4
Owner-vs-guest /health gating
Suite 21a-d
5
Owner-vs-guest X-OLP-Fallback-Detail gating
Suite 21e-h
6
Post-revoke 401 within next request
Suite 19o + Suite 20e
7
Manifest atomicity + revoke-dominates-touch
Suite 19y-1..4
8
Audit ndjson round-trip + PII guard
Suite 20j + 20j-stream + 20j-401
9
Bootstrap keygen surface reproducible
Suite 22
10
OLP_OWNER_TOKEN env override
Suite 19p + Suite 20f
11
providers_enabled 403 scope enforcement
Suite 20h
Known limitations carried beyond v0.2.0
Phase 2 functional scope is complete. The following remain as Phase 3+ deferrals (tracked in docs/v1x-roadmap.md + new entries below):
- Dashboard (
dashboard.html) — owner-only multi-provider quota / fallback / cache-hit-rate panels. Per ADR 0007 § 12 + v0.1 spec § 4.6. Phase 3 mainline.
- Audit query layer + rotation —
audit.ndjson is append-only at v0.2.0; aggregate queries + log rotation deferred to Phase 3 alongside Dashboard.
tried_providers semantics on key_no_provider_access 403 — schema currently reports filter-rejected hops as "tried"; either ADR § 8 amendment (rename / add field) or D46+ semantic fix. Noted by D45 opus reviewer.
- Per-provider per-key auth artifact mapping — ADR § 12 explicit out-of-scope. Per-key cache + audit isolation works; per-key per-provider OAuth tokens (e.g., two OLP keys each authenticated to different OpenAI Codex accounts) is Phase 3+ work.
- SQLite migration (Option 3 hybrid) — ADR § 13 documents the forward path; trigger is Dashboard / SQL-aggregate-quota / multi-second audit-query workload. Requires engines bump (
>=22.13.0 or >=23.4.0) per ADR § 11 as a separate prior PR.
D47 — bin/olp-keys.mjs keygen CLI (Phase 2 functional scope closes)
Fourth Phase 2 implementation D-day. Closes ADR 0007 § 10 acceptance criterion #9 (bootstrap workflow must be reproducible without manual file editing) by shipping a minimal keygen CLI per § 9.1. Phase 2 functional scope is complete with this D-day — remaining work is Phase 2 close → v0.2.0 (maintainer-triggered, explicit per CLAUDE.md release_kit.phase_close_trigger).
- New file
bin/olp-keys.mjs (~250 lines): subcommand CLI with three subcommands:
keygen [--owner] [--name=<label>] [--tier=guest|owner] [--providers=<csv>] [--force] — creates a key + prints plaintext token to stdout ONCE; manifest stores only SHA-256 hash. --force revokes existing owner keys before creating the new owner (recovery flow per ADR § 9.3). --providers=* (default) or comma-separated allowlist.
list [--owner-only] [--include-revoked] — lists keys with token_hash redacted (lib/keys.mjs listKeys already redacts).
revoke --id=<key-id> — marks the key's revoked_at; idempotent (already-revoked → no-op + status message); missing id → exit 2.
- Common flag
--olp-home=<path> overrides ~/.olp/; defaults to OLP_HOME env or ~/.olp/.
package.json bin field: olp-keys → ./bin/olp-keys.mjs so npx olp-keys ... resolves; also npm run olp-keys ... via scripts.
- Module shape: CLI exposes
runCli(argv, { out, err }) so tests can invoke it with synthetic argv + IO writers (no process spawn). Main guard auto-runs when invoked as entrypoint.
- Plaintext token discipline: per ADR § 5 + § 9.1, plaintext is printed exactly once on stdout. Never logged, never written to manifest, never written to audit. Operators must capture immediately; lost →
--force revoke + regenerate.
--force async correctness: cmdKeygen is async and awaits each revokeKey (which is async — acquires per-key write lock per § 6.4). Sequence: revoke each existing owner manifest atomically → then createKey for new owner. Avoids the race where create-new runs before revoke-old completes.
- Test surface (Suite 22, +20 tests — 524 → 544):
- 22a-1..5: parseArgv unit tests (
--flag=value, --flag value, boolean, mixed positional)
- 22b-1..5: keygen subcommand (owner default, name+providers, missing-name error, invalid-tier error, --force revoke-then-create flow with isolation tmpdir)
- 22c-1..3: list subcommand (empty, populated with token_hash-redaction check, --owner-only filter)
- 22d-1..4: revoke subcommand (valid id, idempotent re-revoke, missing-id error, nonexistent-id error)
- 22e-1..3: top-level CLI behaviour (--help / no args / unknown subcommand exit codes)
- Documentation: AGENTS.md
lib/keys.mjs marker promoted to ✅; new bin/olp-keys.mjs entry. Implementation-status-note + shipped-set updated. README.md Implementation Status table gains bin/olp-keys.mjs row; Known limitations note updated to "Phase 2 functional scope complete; close pending"; new "Bootstrap workflow" section with copy-pasteable npx commands + recovery flow.
- Test count: 524 → 544 (+20 D47 tests in Suite 22).
- Authority: ADR 0007 (multi-key auth — § 5 token format, § 9.1 minimal keygen command surface, § 9.3 recovery, § 10 acceptance criterion #9 covered); CLAUDE.md
release_kit overlay phase_rolling_mode — under Unreleased; standing autopilot grant.
D46 — owner-vs-guest gating for /health + X-OLP-Fallback-Detail (Phase 2 closes header observability gap)
Third Phase 2 implementation D-day. Closes ADR 0007 § 10 acceptance criteria #4 (/health payload trimming for non-owner) + #5 (X-OLP-Fallback-Detail emission gating per fallback_detail_header_policy). Phase 2 server surface is now fully gated end-to-end; remaining D-days are keygen CLI surface (D47+) and Phase 2 close (v0.2.0, maintainer-triggered).
server.mjs handleHealth identity-aware payload per ADR § 7.1:
- Auth gate at top —
authenticate(req) returns 401 for unauth + allow_anonymous: false (consistent with /v1/* routes); 200 with trimmed payload for anonymous / guest; 200 with full payload for owner.
- Trim controlled by
_authConfig.owner_only_endpoints — if /health is in the list, non-owner gets { ok: true, version }; else (operator removes it) full payload to everyone (v0.1.1 opt-out knob).
touchLastUsed fired on res.on('finish') for filesystem identities (matches /v1/* pattern). No audit row on /health — high-volume monitoring endpoint, audit volume noise not justified at Phase 2 (would land with Phase 3 Dashboard if aggregate /health stats become needed).
server.mjs withFallbackDetailHeader identity-aware emission per ADR § 7.2:
- New helper
shouldEmitFallbackDetailHeader(olpIdentity) reads _authConfig.fallback_detail_header_policy:
'owner_only' (default) → emit only when olpIdentity.owner_tier === 'owner'
'all' → emit unconditionally (v0.1.1 opt-back-in for operators who want the diagnostic header for all identities)
'none' → suppress unconditionally
- When
olpIdentity is null (pre-auth error paths), defaults to emit — preserves the v0.1.1 ungated behaviour for pre-auth errors where identity is unknown.
withFallbackDetailHeader signature gains a third olpIdentity argument; both call sites in handleChatCompletions updated to pass olpIdentity.
- Test surface (Suite 21, +9 tests + 1 added in Suite 20 — 515 → 524):
- 20m /health with no auth +
allow_anonymous=false → 401 (consistency with /v1/* routes)
- 21a-d /health payload trimming (criterion #4): anonymous trimmed; guest trimmed; owner full;
owner_only_endpoints: [] opts out (guest gets full)
- 21e-h X-OLP-Fallback-Detail emission gating (criterion #5):
owner_only + guest → header absent; owner_only + owner → header present + valid JSON; 'all' + guest → header present (v0.1.1 opt-back); 'none' + owner → header absent (full suppression). Tests use a 2-hop chain (anthropic primary fail + openai secondary) to produce non-empty fallbackDetail for the header content.
- Test-mode setup updated: the global
__setAuthConfig({ allow_anonymous: true }) was extended to also pass owner_only_endpoints: [] + fallback_detail_header_policy: 'all' so pre-D46 tests (Suite 18, F5 /health tests, D40 fallback-detail tests, etc.) continue to pass without modification — Suite 21 explicitly overrides per-case to exercise the production-default-gated paths.
- Documentation: AGENTS.md
lib/keys.mjs marker updated to reflect D46 ship; Implementation-status-note updated. README.md Implementation Status row + Known limitations "Multi-key auth" note rewritten to reflect D46 ship + remaining keygen CLI.
- Test count: 515 → 524 (+9 D46 tests).
- Authority: ADR 0007 (multi-key auth — §§ 7.1 + 7.2 implementation contracts + § 10 acceptance criteria #4 + #5 covered); ADR 0004 Amendment 5 (D40 ratification of "Phase 2 will re-introduce owner-vs-non-owner gating when
lib/keys.mjs lands" — this D-day fulfils the deferral); CLAUDE.md release_kit overlay phase_rolling_mode — under Unreleased; standing autopilot grant (~/.cc-rules/memory/auto/standing_autopilot_phase_2.md in cc-rules bf0ed9a).
D45 — server.mjs auth integration + lib/audit.mjs (Phase 2 wire-up)
Second Phase 2 implementation D-day. Wires the D44 lib/keys.mjs identity layer into the request flow + lands lib/audit.mjs per ADR 0007 § 6.2 + § 8. Closes acceptance criteria #1 (per-key cache isolation, validation-side end-to-end), #2 (anonymous prod-default off), #3 (anonymous dev-mode on), #6 (post-revoke 401 within next request — full), #8 (audit ndjson round-trip), #10 (OLP_OWNER_TOKEN env override — full server-side), #11 (providers_enabled 403 scope). Owner-vs-guest gating for /health + X-OLP-Fallback-Detail (criteria #4, #5) remains in D46 scope.
- New file
lib/audit.mjs (~75 lines): appendAuditEvent(event, opts) writes one JSON event per line to ~/.olp/logs/audit.ndjson (file 0600, dir 0700). § 6.2 retry semantics: warn + 1 retry on first failure; per-process drop counter + warn on second failure; NEVER throws. Per-call OLP_HOME env resolution (matches lib/keys.mjs). Exports getAuditDropCount for future /health surface.
lib/keys.mjs extended with loadAuthConfigSync({ olpHome }) reading the auth block from ~/.olp/config.json with defaults per ADR § 7.2 (allow_anonymous: false, owner_only_endpoints: ['/health'], fallback_detail_header_policy: 'owner_only'). Both lib/keys.mjs + lib/audit.mjs now resolve OLP_HOME env per call (precedence: opts.olpHome → process.env.OLP_HOME → ~/.olp) so tests and operator deployments can redirect without code edits.
server.mjs auth middleware integration:
extractToken(req) parses Authorization: Bearer <token> first, then x-api-key: <token>.
authenticate(req) calls validateKey(token, { allowAnonymous: _authConfig.allow_anonymous }); returns identity on success, 401 { auth_required | invalid_or_revoked_key } on failure.
isProviderEnabled(olpIdentity, providerKey) enforces providers_enabled allowlist ('*' = all).
_authConfig loaded at startup; warn auth_allow_anonymous_enabled fires if allow_anonymous: true so the relaxed posture is visible. Test seams __setAuthConfig / __resetAuthConfig.
handleChatCompletions and handleModels both gated by authenticate(req) at top. Audit ctx object built throughout the handler lifecycle; res.on('finish') appends the row + fires touchLastUsed async (best-effort).
- Identity-vs-credentials separation:
olpIdentity (the new validated identity) is consumed for cache namespacing + providers_enabled + audit; authContext passed to provider.spawn() REMAINS null so providers continue their own credential discovery (env / keychain / file). Per-provider per-key credential mapping is Phase 3+ scope per ADR § 12.
handleChatCompletions chain filtered by chain.filter(hop => isProviderEnabled(olpIdentity, hop.provider)); empty result returns 403 key_no_provider_access with helpful diagnostic message.
keyId = olpIdentity.keyId (replacing hardcoded '__anonymous__' at the cache call sites).
- Audit captures fields throughout: post-auth (key_id, owner_tier); post-IR (model); post-chain-success (provider, fallback_hops, tried_providers, cache_status); post-chain-exhausted (error_code, providerUsed=chain[0], cache_status='miss'). Status code + latency populated on
res.on('finish').
- Test surface (Suite 20, +15 tests, 499 → 514):
- 20a-d: header parsing + valid key happy paths (Bearer / x-api-key / invalid → 401)
- 20e: revoked key 401 (closes criterion #6 end-to-end)
- 20f:
OLP_OWNER_TOKEN env override returns 200 (criterion #10 full coverage)
- 20g:
allow_anonymous: true + no header returns 200 (criterion #3)
- 20h + 20h-extra:
providers_enabled: ['mistral'] for anthropic model → 403; '*' baseline returns 200 (criterion #11)
- 20i: per-key cache namespace isolation — keys A/B with identical payload do not share cache (criterion #1 end-to-end)
- 20j + 20j-401: audit.ndjson written with § 8 schema fields including PII guard; 401 path also appends (criterion #8)
- 20k: filesystem key
last_used_at populated after first successful request (D45 touchLastUsed wire)
- 20l + 20l-200:
/v1/models also enforces auth (consistent gating across /v1/*)
- Test-mode setup: test-features.mjs sets
process.env.OLP_HOME to a tmpdir at module load so audit + key writes don't pollute ~/.olp/. After the server.mjs import resolves, calls __setAuthConfig({ allow_anonymous: true }) so pre-D45 HTTP integration tests (Suite 18 etc.) that don't pass an Authorization header continue to pass as anonymous; Suite 20 explicitly overrides per-case for production-default-off coverage.
- Documentation: AGENTS.md
lib/keys.mjs 🟡 marker updated + new lib/audit.mjs entry; AGENTS.md Implementation-status-note + shipped-set updated. README.md Implementation Status table gains lib/audit.mjs row + lib/keys.mjs row updated; Known limitations "Multi-key auth" note rewritten to reflect D45 ship + D46 follow-up; new env-vars and config block surfaced for users.
- Test count: 499 → 515 (+15 initial Suite 20 tests + 1 fold-in regression test
20j-stream covering opus-P1 streaming audit-fidelity).
- Fold-in (CI-fail recovery + fresh-context opus reviewer findings, 1 CI + 1 P1 + 2 P2 + 1 P3):
- CI Node 24 failure — Suite 20 setup did not stub
CLAUDE_CODE_OAUTH_TOKEN before the mock spawn ran; lib/providers/anthropic.mjs _spawnAndStream checks for an OAuth token BEFORE invoking the (mock) spawn, so the AUTH_MISSING pre-check fired and every Suite 20 200-expecting test 502'd on CI Node 24 (local Node 22 had the env from the maintainer's claude install). Fixed by ensureSuite20FakeOAuth / restoreSuite20OAuth helpers in makeSuite20Server / teardownSuite20; matches the existing pattern used at Suite 9 line ~2154 (test-fake-oauth-token-for-cache-tests).
- P1 real-streaming audit fidelity — single-hop streaming success path (server.mjs ~L1050+
if (ir.stream && chain.length === 1 && !bypassCacheForFirstHop ...)) did not populate auditCtx.provider / tried_providers / cache_status, so audit rows for the most common deployed shape carried provider: null. Fixed by stamping these fields at the top of the streaming branch (between the streamPlugin null-check and the streamHeaders build) and amending error_code on the two streaming failure exit paths (streaming_error_after_first_chunk + streaming_error_before_first_chunk). New regression test 20j-stream makes a streaming request and asserts the audit row's provider, cache_status, and tried_providers fields are populated.
- P2 global test tmpdir cleanup —
process.env.OLP_HOME = mkdtempSync(...) at module load left a /var/folders/.../olp-test-home-* directory leak per npm test run. Fixed by process.on('exit', () => rmSync(...)) registered immediately after the mkdtempSync. Best-effort; never throws at exit.
- P3 handleModels 401 lacks OLP diagnostic headers —
handleChatCompletions 401 path passes olpErrorHeaders({ startMs }) but handleModels did not. Aligned by adding the same headers to the handleModels authResult.ok=false return.
- Deferred (acknowledged by reviewer as non-blocking): P2
tried_providers semantics on key_no_provider_access 403 — schema currently reports filter-rejected hops as "tried" which a downstream Dashboard would misread; either ADR § 8 amendment (rename / add field) or D46+ semantic fix.
- Authority: ADR 0007 (multi-key auth — §§ 5/6.2/7/9.4 implementation contracts + § 10 acceptance criteria #1/#2/#3/#6/#8/#10/#11); CLAUDE.md
release_kit overlay phase_rolling_mode — under Unreleased; Phase 2 kickoff handoff (~/.cc-rules/memory/handoffs/2026-05-25-phase-2-kickoff.md in cc-rules d9da966); standing autopilot grant (~/.cc-rules/memory/auto/standing_autopilot_phase_2.md in cc-rules bf0ed9a).
D44 — lib/keys.mjs core landed (multi-key auth, no server wire-up yet)
First Phase 2 implementation D-day. Lands the lib/keys.mjs module per ADR 0007 §§ 5/6.1/6.3/6.3.5/6.4/9.4. Identity / lifecycle layer for OLP API keys is now in-tree; server.mjs integration scheduled D45 (until then, requests still use the hardcoded '__anonymous__' cache namespace — no behavioural change at v0.1.1 / D44).
- New file
lib/keys.mjs (~462 lines after fold-in) — public API surface:
createKey({ name, owner_tier, providers_enabled, notes, olpHome }) — generates opaque olp_<32-byte base64url> token (47-char total), SHA-256 hashes it for manifest storage, atomically writes keys/<id>/manifest.json (mode 0600, dir 0700). Returns { id, plaintext_token, manifest } — plaintext token is printed once and never persisted.
validateKey(plaintext, { allowAnonymous, olpHome }) — three-tier resolution per § 5 / § 7 / § 9.4: env override (OLP_OWNER_TOKEN → __env_owner__ synthetic identity) → anonymous (only when allowAnonymous: true, returns __anonymous__ identity) → filesystem manifest lookup (constant-time hash compare via crypto.timingSafeEqual). Revoked manifests return null (caller produces 401). Per § 6.3.5 — MUST hit manifest every request; no in-process validation cache.
revokeKey({ id, olpHome }) — idempotent; sets revoked_at via atomic write inside per-key write-lock.
listKeys({ olpHome }) — returns manifest objects with token_hash redacted.
touchLastUsed(id, { olpHome }) — async best-effort lazy update per § 6.3 revoke-dominates-touch: re-reads latest manifest inside the per-key lock, NO-OPs if revoked_at is non-null, otherwise merges last_used_at preserving all other fields. Failure logs warn and never throws.
- § 6.4 in-process per-key write-lock —
Map<key-id, Promise> chain; serializes intra-process writes. External (CLI) writes not lock-protected at Phase 2; atomic-rename + § 6.3 read-before-write give the revoke dominates touch safety property.
- Test-only hooks —
__setTouchInterleaveHook (inject deterministic pause between touch's lock acquisition and read for race tests) + __resetWriteLocks (test cleanup).
- What is NOT in D44 (split per ADR §§ 6.2 / 9.1 separation): audit ndjson append (request-layer concern; D45 server glue); keygen CLI bootstrap surface (D45+);
server.mjs integration replacing the hardcoded '__anonymous__' keyId at server.mjs:502, :531 (D45); owner-vs-guest gating for /health and X-OLP-Fallback-Detail (D46).
- Test count: 468 → 496 (+28 tests in new Suite 19):
- 19a-d token generation (§ 5)
- 19e-j manifest write+read + chmod 0600/0700 + schema validation (§ 4, § 6.1)
- 19k-p validateKey: filesystem / wrong / missing / anonymous / revoked / env override (§ 5, § 6.3.5, § 9.4)
- 19q-r revokeKey idempotency + non-existent id
- 19s-t listKeys empty + redaction
- 19u-x touchLastUsed updates + NO-OP on revoked + NO-OP on anonymous/env identities + best-effort failure
- 19y-1 to 19y-4 acceptance criterion #7 (concurrent revoke + touch race tests): revoke→touch, touch→revoke, interleaved external-revoke-via-hook (deterministically reproduces the § 6.3 race the maintainer's text review caught), 30-iteration concurrent-promise stress
- Documentation: AGENTS.md
lib/keys.mjs 📋 marker → 🟡 "core landed at D44"; AGENTS.md Implementation-status-note + shipped-set updated to include lib/keys.mjs; README.md Implementation Status row + Known limitations "Multi-key auth" note updated to "core landed, server integration pending D45".
- Fold-in (fresh-context opus reviewer findings, 2 P2 correctness + 2 P3 polish):
- P2 #1 lock-map cleanup (
lib/keys.mjs _withKeyLock): prior version stored prev.then(() => next) as the Map tail, but the cleanup-identity check _writeLocks.get(id) === next could never match the derived promise — Map entries leaked one-per-unique-key-id. Bounded impact at family scale (~5–10 entries) but a real correctness bug. Fixed by storing next directly. New regression tests 19x-extra (sequential) + 19x-extra-2 (concurrent 3-key × 3-touch contention) assert __writeLockSize() === 0 post-drain.
- P2 #2
validateKey non-string defensive coding: prior version threw TypeError when called with a non-string truthy plaintext (validateKey(42) / validateKey({})), reaching hashToken(<non-string>) → createHash().update(<non-string>). Q2 promised "bad inputs return null." Fixed via top-of-function if (plaintextToken != null && typeof plaintextToken !== 'string') return null;. New test 19m-extra covers number / object / array / allowAnonymous: true paths.
- P3 #3 19y-3 test scope comment: test simulates external revoke landing BEFORE touch's read, not BETWEEN touch's read and write (which is currently unreachable because
touchLastUsed has synchronous read→write — no await between readManifest and writeManifestAtomic). Added explanatory comment documenting the synchronous-read-write property as the satisfaction mechanism for ADR § 10 criterion #7 scenario 3, with a note that a post-read hook + matching test would be required if a future refactor introduces an await between read and write.
- P3 #4 CHANGELOG line count: corrected
~330 lines to ~462 lines after fold-in (matches wc -l lib/keys.mjs).
- Test count after fold-in: 468 → 499 (+31 tests: 28 initial + 3 fold-in regression tests).
- Authority: ADR 0007 (multi-key auth — Decision: Option 2 filesystem manifest + opaque token; §§ 5/6.1/6.3/6.3.5/6.4/9.4 implementation contracts; § 10 acceptance criteria #6/#7 partially-covered by D44 tests, full coverage requires D45+ server integration); CLAUDE.md
release_kit overlay phase_rolling_mode — under Unreleased; Phase 2 kickoff handoff (~/.cc-rules/memory/handoffs/2026-05-25-phase-2-kickoff.md in cc-rules d9da966); PR #20 fresh-context opus reviewer findings.
D43-B — ADR 0007 multi-key auth design draft (design-only, no code change)
Phase 2 mainline design ADR. Ratifies the storage / token / manifest / atomic-write / owner-gating / bootstrap / Node-baseline decisions ahead of D44+ implementation D-days. Pure design doc — no .mjs / no tests / 4 files touched.
docs/adr/0007-multi-key-auth.md (new, ~420 lines after fold-ins): 13 sections covering Context / Decision (Option 2 + opaque key) / Storage layout (~/.olp/keys/<key-id>/manifest.json + ~/.olp/logs/audit.ndjson) / Manifest schema (schema_version, token_hash, owner_tier, providers_enabled) / Token format (olp_<32-byte base64url>, SHA-256 hash) / Atomic write & audit append (manifest lifecycle-only atomic via tmpfile+fsync+rename; audit per-request append, warn + 1 retry, no memory buffer at Phase 2) / Owner-vs-guest-vs-anonymous gating (config.json auth.allow_anonymous default false, no env auto-detection) / Audit ndjson schema (no PII) / Bootstrap & recovery (minimal keygen command surface + OLP_OWNER_TOKEN env override with stable __env_owner__ keyId) / Acceptance criteria (11 test surfaces for D44+) / Node baseline (Option 1 SQLite port rejection rationale citing engines >=18 + CI 20/24 vs node:sqlite v22.5.0 with flag) / Out of scope (Dashboard, quota enforcement, audit query, file locking deferred to Phase 3+) / Future forward (Option 3 hybrid migration trigger + preconditions).
docs/adr/README.md index: added ADR 0007 row with one-paragraph summary.
docs/v1x-roadmap.md #2: marked PHASE 2 ACTIVE (no longer deferred); "Design ADR (NOT YET RATIFIED)" → "Design ADR (ratified) → ADR 0007"; trigger updated to "already fired 2026-05-25"; code anchors pinned to exact line numbers (cache/store.mjs:77-79/:287, server.mjs:502/:531/:392/:1072/:1101).
CHANGELOG.md Unreleased: this entry.
- Fold-in #1 (fresh-context opus reviewer findings, 2 P2 + 3 P3, all polish): § 6.2 step 1 — pin audit serialization timing to after status_code + latency_ms are known (resolves §10 #2 testability gap); new § 6.3.5 — explicit "no in-process validation cache at Phase 2" rule (resolves §10 #6 implicit-contract gap); § 6.1 — document deliberate omission of directory fsync after rename (single-process trade-off); § 9.4 — token-collision policy between
OLP_OWNER_TOKEN and filesystem keys declared undefined behaviour; §10 #4 — test rephrased to assert against config-driven owner_only_endpoints rather than hardcoded payload shape.
- Fold-in #2 (maintainer text-review findings, 1 P1 + 1 P2 + 1 P3): § 6.3 rewritten to
last_used_at revoke-dominates-touch semantics (P1 — fixes safety bug where lazy touch could overwrite revoke and silently clear revoked_at, breaking acceptance criterion #6 under concurrent CLI revoke + in-flight server request); § 6.4 reframed from "both states are valid" / "observability-grade" to "revoke dominates touch" with §6.3 as the load-bearing discipline; § 10 criterion #7 expanded to test all three orderings (revoke→touch, touch→revoke, interleaved) with explicit MUST: revoked_at non-null after revoke regardless of ordering; § 11 forward path step (1) corrected Node version history — minimum non-flag-gated baseline is v22.13.0 (LTS) / v23.4.0 (current), RC since v25.7.0, stable TBD (previous wording "Node v22.5.0+ for unflagged but RC" was factually wrong per https://nodejs.org/download/release/v22.12.0/docs/api/sqlite.html and https://nodejs.org/api/sqlite.html); this CHANGELOG entry line-count corrected from "~270 lines" to "~420 lines after fold-ins".
- Test count: 468 → 468 (design-only, no test change).
- Authority: Phase 2 kickoff handoff (
~/.cc-rules/memory/handoffs/2026-05-25-phase-2-kickoff.md in cc-rules d9da966); OLP v0.1 spec § 4.5 (planning authority for ~/.olp/ layout); OCP keys.mjs (prior-art for opaque-key + per-key isolation model); Node node:sqlite docs (https://nodejs.org/api/sqlite.html — Option 1 rejection rationale per ADR 0007 § 11); CC 开发铁律 v1.6 § 10 — fresh-context opus reviewer required for design ADR per Iron Rule 10.
D43-A — Phase 2 doc alignment (no code change)
Phase 1 was closed at v0.1.1; this commit aligns documentation surfaces to the Phase 2 reality before D43-B (ADR 0007 draft) lands. Pure doc cleanup; no .mjs or test changes.
CLAUDE.md release_kit.current_phase Phase 1 → Phase 2; current_pre_release_identifier 0.1.0-bootstrap → 0.2.0-phase2.
README.md status header + Implementation Status + Phase plan rewritten to reflect actually-shipped reality (v0.1.0 + v0.1.1 bundled the three Tier-D plugins + cache + fallback into a single Phase 1 milestone, not one phase per plugin as the original v0.1 spec planned). lib/keys.mjs row + "Multi-key auth not yet implemented" note updated to "Phase 2 active per ADR 0007 (drafting at D43-B)".
AGENTS.md § Key files to know — lib/keys.mjs 📋 marker updated to "Phase 2 active per ADR 0007 (drafting at D43-B)"; Implementation-status-note paragraph dated 2026-05-25 + reflects Phase 1 close + Phase 2 active scope.
ALIGNMENT.md § Provider Inventory — added one-paragraph "Note on phase terminology" clarifying that "Phase" in the Provider Inventory tables + § One-shot Triggered Audits "OpenAI Codex ToS formal pin" refers to the original per-plugin enablement plan, orthogonal to the milestone phase numbering in README. Fold-in for D43-A reviewer P2 finding; no governance-text change, no Speculative-Candidate plugin reclassification.
- Test count: 468 → 468 (no test change).
- Authority:
CLAUDE.md release_kit overlay phase_rolling_mode — under Unreleased; Phase 2 kickoff handoff at ~/.cc-rules/memory/handoffs/2026-05-25-phase-2-kickoff.md; ADR 0007 forthcoming at D43-B.
v0.1.1 — 2026-05-25
Phase 1 cleanup — pre-Phase-2 batch (D35–D42, closes 16 of 17 issues)
Overview. v0.1.1 closes the post-v0.1.0 cleanup batch covering all 17 pre-Phase-2 issues raised during the 6-round cold-audit cycle on the Phase 1 deliverable. 8 D-day commits (D35–D42) shipped between 2026-05-24 and 2026-05-25. 16 issues closed; issue #16 (streaming singleflight) stays OPEN as the v1.x tracker with its design ratified in ADR 0005 Amendment 8.
Test count: 416 (v0.1.0) → 468 (v0.1.1). +52 tests across the cleanup batch.
D35 — pre-Phase-2 batch #1 (issues #4 #9 #10 #11 #12)
- #4 — X-OLP-Latency-Ms uniform. Audit confirmed already-correct via D32; D35 adds the
#4-audit regression test pinning the 5-header invariant on the 503 no-provider sendError so future drift is caught immediately.
- #9 — Streaming empty-then-clean-exit headers. Zero-chunk streaming path now guards
!res.headersSent and emits Content-Type=text/event-stream, Cache-Control=no-cache, Connection=keep-alive, X-Accel-Buffering=no, plus all 5 X-OLP-* headers via olpHeaders before writing SSE_DONE. Zero-chunk path correctly does NOT cache.
- #10 — Streaming post-first-chunk error truncation marker. Two sibling fixes: catch-block-firstChunkEmitted=true and error-chunk-after-first-chunk both now emit synthetic
{type:'stop', finish_reason:'length'} via irChunkToOpenAISSE + SSE_DONE + res.end(). Per ADR 0004 § Fallback safety: post-first-chunk truncation surfaces as length finish, never a hang.
- #11 —
validateIRRequest irVersion strict check. ADR 0003 IR contract pins irVersion to '1.0'. Validator now: obj.irVersion !== undefined && obj.irVersion !== '1.0' → rejection. Strict string match — undefined accepted (back-compat), '1.0' accepted, '2.0' rejected, numeric 1.0 rejected (1.0 !== '1.0').
- #12 —
alignment.yml scripts/ trigger removal.** Removed from both push.paths and pull_request.paths since the scripts/ directory does not currently exist (planned for Phase 7).
- Test count: 416 → 424 (+8).
D36 — pre-Phase-2 batch #2 (issues #2 #5 #6 #13 #14 #15)
- #2 — cache_control partial-noop debug log.
server.mjs handleChatCompletions fires logEvent('debug', 'cache_control_partial_noop', { chain, marker_count }) at most once per request when markers present AND chain has at least one non-Anthropic hop. Per ADR 0005 § D2.
- #5 — ADR 0002 vibe.mjs → mistral.mjs. § Decision filesystem layout corrected to match the shipped file naming convention (file named after provider key, not CLI binary). Amendment 5 documents the correction + makes the convention statement explicit for future contributors.
- #6 — mistral.mjs A5 flip + ALIGNMENT.md table update. Header A5 (model flag) flipped from
UNPINNED-D-later-verifies to CONFIRMED-NOT-APPLICABLE with DeepWiki citation; ALIGNMENT.md Speculative-Candidate table mistral row updated to remove A5.
- #13 — /v1/models alias governance. ALIGNMENT.md gains "Controlled deviations (entry-surface scope)" subsection documenting the alias surface as a controlled Rule 2(b) deviation;
docs/openai-spec-pin.md gains the alias-surfacing subsection with full 4-field contract table.
- #14 — cache_control slot determinism regression test. 4 tests in test-features.mjs construct hand-built IRs with synthetic markers (bypassing openAIToIR which strips them at v0.1) and verify the cache key SHA-256 is deterministic. Per ALIGNMENT.md Rule 2 (No Invention), no
sortMarkers helper shipped — the slot is dead-code at v0.1.
- #15 — Anthropic v2.1.89 transcript artifact. New file
docs/provider-audits/anthropic.md as a single living version-capture artifact. Records observed claude --version (2.1.132 at capture date 2026-05-24), pinned version (v2.1.89 from D4), drift note, sample invocation, flag-surface table for 5 OLP-consumed flags. Closes the circular ALIGNMENT.md ↔ plugin header citation by anchoring on an external artifact.
- Test count: 424 → 431 (+7).
D37 — release.yml phase_rolling_mode gate (issue #17)
- CI gate enforcing phase_rolling_mode promotion discipline. New "Enforce phase_rolling_mode (Unreleased must be promoted)" step in
release.yml between the version-match check and the CHANGELOG extraction step. Awk extracts content between ## Unreleased and the next ## heading; sed strips blank lines and parenthetical-sentinel-only lines. Non-trivial remaining content fails the workflow with ::error:: instructing the maintainer to promote Unreleased → ## v<version> per CLAUDE.md release_kit.phase_rolling_mode.
- Dry-run validated against 4 cases: current sentinel-only Unreleased → PASS; synthetic non-trivial Unreleased → FIRES with offending lines reported; no Unreleased section → PASS; multi-sentinel + blank lines → PASS.
- Gate is purely additive — fires only on tag push to
v*.*.*, does not affect normal push/PR CI.
- Test count: 431 → 431 (no test change — CI workflow only).
D38 — maxConcurrent runtime enforcement (issue #1)
-
Spawn lifecycle gate — hints.maxConcurrent is now enforced at runtime per ADR 0002 Amendment 6: lib/providers/index.mjs exports a per-provider tryAcquireSpawn / releaseSpawn / getActiveSpawnCount semaphore; server.mjs gates both the buffered and streaming spawn call sites in handleChatCompletions with a try/finally release. Saturation surfaces as ProviderError(CONCURRENCY_LIMIT) which the fallback engine treats as a hard trigger (ADR 0004 Amendment 4) — the chain advances to the next hop instead of queueing. If the entire chain is saturated, the user receives a chain-exhausted error via the existing exhaustion path. Closes #1. Queue+timeout deferred (see ADR 0002 Amendment 6 § Design choice). Test count 431 → 447.
-
Spawn lifecycle gate — hints.maxConcurrent is now enforced at runtime per ADR 0002 Amendment 6: lib/providers/index.mjs exports a per-provider tryAcquireSpawn / releaseSpawn / getActiveSpawnCount semaphore; server.mjs gates both the buffered and streaming spawn call sites in handleChatCompletions with a try/finally release. Saturation surfaces as ProviderError(CONCURRENCY_LIMIT) which the fallback engine treats as a hard trigger (ADR 0004 Amendment 4) — the chain advances to the next hop instead of queueing. If the entire chain is saturated, the user receives a chain-exhausted error via the existing exhaustion path. Closes #1. Queue+timeout deferred (see ADR 0002 Amendment 6 § Design choice). Test count 431 → 447.
D39 — D16 follow-ups (issue #3): explicit cache delete + eviction log + SPAWN_TIMEOUT asymmetry doc
- Part 1 —
CacheStore.delete(keyId, cacheKey) — adds an explicit eviction primitive to lib/cache/store.mjs. Returns boolean (true if entry present and removed; false otherwise) and removes empty per-keyId namespace Map entries from the outer store for memory hygiene (matches the D38 _activeSpawns pattern). server.mjs D16 salvage path replaces cacheStore.set(..., ttlMs=0) (lazy tombstone that lived in the namespace Map until the next get/peek purged it) with cacheStore.delete(...) (immediate removal). Cache semantics unchanged — truncated responses still don't persist. ADR 0005 § "Cache write conditions" item 1 authority.
- Part 2 —
cache_evicted_truncated observability log — adds an info-level structured log event fired immediately after the D16 eviction in executeHopFn. Carries { provider, model } so dashboards can surface salvage frequency per (provider, model) pair. P3 polish; no semantic change.
- Part 3 — sticky-cache regression test — defense-in-depth test asserting two consecutive identical buffered requests that both trigger SPAWN_FAILED-with-chunks salvage each invoke a fresh spawn (spawnCount=2 across the two requests; second request reports
X-OLP-Cache: miss). Catches any future regression where the eviction is dropped or the gate condition flips.
- Part 4 — SPAWN_TIMEOUT salvage asymmetry documented (no code change) — ADR 0004 Amendment 1 gains a new sub-section "Why SPAWN_TIMEOUT is excluded from salvage" with a 4-point rationale: (1) SPAWN_FAILED is a terminal signal, SPAWN_TIMEOUT is a deadline signal; (2) the next hop is a different provider with different speed characteristics, plausibly full-response-soon-after-T; (3) the "user paid for partial" framing applies to SPAWN_FAILED only — for SPAWN_TIMEOUT the user paid for "result within T"; (4) code inspection confirms the catch block matches only
code === 'SPAWN_FAILED'. Includes hard-trigger-taxonomy completeness note and v1.x re-evaluation trigger (opt-in salvage-on-timeout for long deadlines).
- Authority: ADR 0005 § Cache layer / CacheStore API extension (Part 1); ADR 0004 Amendment 1 (Part 4); GitHub issue #3 — closed by this commit; D16 commit
bafa6d1 non-blocking suggestions — batched here.
- Test count: 447 → 452 (3 unit tests for
CacheStore.delete + 1 log-event integration test + 1 sticky-cache regression test).
D40 — X-OLP-Fallback-Detail header (issue #7)
- New debug header on responses with a non-empty failure trail —
lib/fallback/engine.mjs#executeWithFallback now returns a fallbackDetail array of per-hop tuples on every code path. server.mjs emits X-OLP-Fallback-Detail: <JSON-stringified array> on any response where at least one hop failed before the chain resolved or exhausted (chain-exhausted, non-trigger-error, client-error, AUTH_MISSING, and success-with-prior-failure paths). Header is absent on clean primary success (no failure trail to report).
- Tuple schema —
{ hop, provider, model, code, error_message, trigger_type } per failed hop. code is the ProviderError code or 'UNKNOWN' for non-ProviderError exceptions; error_message is truncated to 200 chars with a U+2026 ellipsis on truncation; trigger_type matches D28's classifyTrigger output ('hard' / 'soft' / 'auth_missing' / 'client_error' / 'non_trigger'). Field shapes reuse D28's per-hop structured log event keys so logs and the header pivot on the same surface.
- 4KB UTF-8 byte cap — if the JSON-stringified array exceeds 4096 bytes, tail tuples are dropped and a
{ truncated: true, omitted_hops: N } sentinel is appended such that the total fits under the cap. Cap calculation uses Buffer.byteLength('utf8'), not string length.
- RFC 7230 hygiene — non-ASCII code points (e.g. the em dash in the D38
CONCURRENCY_LIMIT synthesised error message) are escaped as \uXXXX so the header value is pure ASCII. Node's HTTP header validator rejects multi-byte UTF-8 in field values; without this step, em-dash-bearing error messages would crash res.writeHead. JSON.parse round-trips the escaped form correctly.
- Gating posture — ungated at v0.1 — the original ADR 0004 § Chain advancement step 4 specified owner-only gating. Per the maintainer decision in issue #7, v0.1 ships the header ungated (single-tenant family-scale per ALIGNMENT.md; no PII risk in error details). Phase 2 will re-introduce owner-vs-non-owner gating when
lib/keys.mjs lands — explicit follow-up tracked in AGENTS.md § Key files to know and ADR 0004 Amendment 5.
- Authority: ADR 0004 § Decision § Chain advancement step 4 (original promise — D40 fulfils it); ADR 0004 Amendment 5 (D40 ratification); D18 (5 standard X-OLP-* headers; D40 builds on the convention); D28 (per-hop structured log fields; D40 reuses the field shapes); GitHub issue #7 — closed by this commit.
- Test count: 452 → 468 (7 engine-level tuple-shape tests + 6 serialiser unit tests including the 4KB cap + non-ASCII regression + 3 HTTP integration tests).
D41 — X-OLP-Provider-Used semantics documented (issue #8)
- Doc-only clarification. On a chain-exhausted response,
X-OLP-Provider-Used identifies the chain's configured primary entry (chain[0].provider), not necessarily the first hop where spawn() was actually invoked. At v0.1 this is unobservable because soft triggers are deferred (ADR 0004 Amendment 2) — every hop is attempted in order, so chain-origin and first-attempted are equivalent. When soft triggers reactivate in v1.x, a soft-skipped hop 0 followed by hard-failed hops 1+N would still report providerUsed=chain[0] despite chain[0] never being spawned.
- Option B (document chain-origin) chosen over Option A (track
firstAttemptedProvider). Rationale: Option A would add state to executeWithFallback for an unreachable v0.1 code path (ALIGNMENT.md Rule 2 — No Invention). The D40 X-OLP-Fallback-Detail header already carries precise per-hop spawn history (including soft-skip records with trigger_type: 'soft'), so the disambiguation channel exists on the wire without needing providerUsed to handle it.
- Updates: ADR 0004 Amendment 6 documents the semantics;
README.md § Observability headers replaces "which provider's plugin served the request" with the chain-origin wording; lib/fallback/engine.mjs chain-exhausted return site gains an inline comment citing the amendment and the v1.x re-evaluation note.
- No code-behavior change. No new tests — the relevant scenario is dead-by-config at v0.1; the v1.x soft-trigger reactivation work should add a test that exercises the soft-skip + chain-exhausted edge case and pins whichever option the v1.x maintainer chooses (the amendment names Option A as the likely v1.x preference).
- Authority: ADR 0004 Amendment 6 (this commit); ADR 0004 § Decision § Chain advancement step 4; ADR 0004 Amendment 2 (soft triggers deferred — precondition); ADR 0004 Amendment 5 (per-hop attribution channel via
X-OLP-Fallback-Detail); ALIGNMENT.md Rule 2 (No Invention rationale); GitHub issue #8 — closed by this commit.
- Test count: 468 → 468 (no test change).
D42 — Streaming singleflight design ADR + v1.x roadmap (issue #16)
- Design-only ratification of the v1.x streaming singleflight implementation. ADR 0005 Amendment 6 (D34) had deferred this work with a "design alone warrants a dedicated ADR" note. D42 fulfils the note as ADR 0005 Amendment 8, ratifying the
cacheStore.getOrComputeStreaming(...) API shape, per-(keyId, cacheKey) inflight Map, tee fan-out with bounded per-client backpressure queues, late-joiner replay buffer, AbortController propagation on all-disconnect, D38 tryAcquireSpawn coordination (only the first caller's spawn counts against the semaphore), cache TTL race handling, the new STREAM_BACKPRESSURE error code (NOT a hard trigger), and the new X-OLP-Streaming-Inflight: source | attached | solo header. Implementation acceptance criteria are enumerated in Amendment 8 §13.
- Multi-layer safeguards to ensure the v1.x work is not forgotten. New file
docs/v1x-roadmap.md is a single living landing page for every Phase-1 deferral (streaming SF, multi-key auth, soft-trigger reactivation, /health activeSpawns, provider-level cacheKeyFields, streaming-path SPAWN_FAILED salvage, D40 AUTH_MISSING tuple test). Each entry names the ratifying ADR, the load-bearing code anchor, and a concrete trigger to start. Cross-references added at: lib/cache/store.mjs#getOrCompute JSDoc (sibling API TODO), server.mjs streaming-branch entry (~line 810, the peek+spawn pattern Amendment 8 replaces), README.md § Known limitations (user-facing surface), and docs/adr/0005-cache-cross-provider.md Amendment 8 § "Cross-references and safeguards".
- Issue #16 status. STAYS OPEN as the v1.x implementation tracker. The body of the issue is updated post-D42 to reference Amendment 8 and clarify scope ("design ratified; implementation pending"). DO NOT close the issue until Amendment 8 §13's test surface is green against an actual implementation.
- No code-behavior change. No new tests. Amendment 8 is design-only. The implementation will go through full Iron Rule 10 (fresh-context opus reviewer + acceptance-criteria-gated test pass) when the v1.x sprint kicks off.
- Authority: ADR 0005 Amendment 8 (this commit); ADR 0005 Amendment 6 (D34 — original deferral note); GitHub issue #16 (round-6 F13 — sibling TOCTOU); ADR 0002 Amendment 6 (D38 —
tryAcquireSpawn semantics that §7 coordination builds on); ADR 0004 Amendment 5 (D40 — observability pattern §11 extends); CLAUDE.md release_kit_overlay phase_rolling_mode — under Unreleased; CC 开发铁律 v1.6 § 10.x (design-only amendment; fresh-context reviewer not required per the Iron Rule 10 implementation-phase scope, documented in the amendment's procedural mechanism).
- Test count: 468 → 468 (no test change — design-only).
Phase 1 cleanup release_kit checklist
- All 8 D-day deliverables landed on main (D35-D42)
- CI green on every D-day commit + on this release commit's head
- Cold-audit round 7 (fresh-context opus full-pass) — PASS_WITH_MINOR, 0 P1/P2 findings
- 16 of 17 pre-Phase-2 GitHub issues closed (#1-#15 and #17); #16 stays OPEN as v1.x tracker
- Issue #16 status comment posted referencing ADR 0005 Amendment 8 design ratification
- CHANGELOG "Unreleased" promoted to "## v0.1.1 — 2026-05-25" with D35-D42 entries
package.json bumped from 0.1.0 → 0.1.1
docs/v1x-roadmap.md created — 7 deferred items with anchors + start triggers
- Tag pushed (next step in this PR's lifecycle)
release.yml triggered + GitHub Release created (auto on tag push; D37 phase_rolling_mode gate will pass because Unreleased is now sentinel-only)
Known limitations carried to v1.x
Full list with code anchors + start triggers in docs/v1x-roadmap.md:
- Streaming-path singleflight (issue #16, ADR 0005 Amendment 8 design ratified)
- Multi-key auth (
lib/keys.mjs)
- Soft-trigger reactivation (ADR 0004 Amendment 2)
/health activeSpawns integration (ADR 0002 Amendment 6 forward note)
- Provider-level
cacheKeyFields mask (ADR 0005 Amendment 7 forward note)
- Streaming-path SPAWN_FAILED salvage (bundled with #1 in v1.x)
- D40 AUTH_MISSING tuple test coverage (test polish)
v0.1.0 — 2026-05-24
Phase 1 Close — Multi-provider proxy core
Overview. Phase 1 delivers the OLP minimum-viable multi-provider proxy: OpenAI-compatible HTTP entry surface, plugin architecture for 3 Tier-D providers (Anthropic Claude / OpenAI Codex / Mistral Vibe), cache layer (D1 per-key isolation + D4 buffered-path singleflight + size cap + cacheable opt-out), fallback engine with first-chunk safety + spawn-timeout hard trigger + structured per-hop log observability, IR↔OpenAI translation honoring the Rule 2(b) no-invention constraint, and a 416-test suite covering all of it.
Released under phase_rolling_mode (CLAUDE.md release_kit overlay): 25 D-day commits accumulated on main between 2026-05-23 and 2026-05-24 before this version bump + tag.
Provider posture. Three Tier D plugins ship as Candidate (per ALIGNMENT.md § Provider Inventory) — runnable via providers.enabled config but not Enabled by default. Five additional Tier B/C plugin slots exist in models-registry.json as Speculative-Candidate / candidate stubs awaiting CLI authority pins. Zero Enabled providers at v0.1; transition to Enabled requires Phase audit + primary-source pin per ADR 0002.
What landed (D10–D34 commit index)
The per-commit detail is in the git log; this index summarizes the deliverables.
Phase 1 core hardening:
- D10 (
2cfd0b1) — P1 round-3: providers.enabled config wiring + real SSE streaming on single-hop cache-miss + spawn-timeout hard trigger across all 3 plugins.
Round-1 fold-in batch (cold audit caught 17 findings):
- D11 (
f659e29) — ADR 0002 Amendment 1: maxSpawnTimeMs ratified into Provider contract hints.
- D12 (
4b1a9c8) — IR translator Rule 2(b) compliance: removed invented top-level error field on chat.completion shapes.
- D13 (
f34b690) — Per-hop cache_control bypass evaluation (was request-global).
- D14 (
a7085d9) — Defer res.writeHead(200) until first chunk; early-error returns 502 JSON instead of 200 empty SSE.
- D15 (
8ae77c3) — ADR 0005 Amendment 2: cache key includes max_tokens / top_p / stop / tool_choice.
- D16 (
bafa6d1) — ADR 0004 Amendment 1: SPAWN_FAILED-with-chunks salvage (don't discard partial responses).
- D17 (
cb86807) — Alias routing SPOT via models-registry.json; getProviderForModel canonicalizes.
- D18 (
82ff007) — /v1/models populated from registry; 5 standard X-OLP-* headers on error responses.
- D19 (
ed82e65) — Cleanup batch: finish_reason validator, dead alignment.yml KNOWN_PROVIDERS removal, unused imports.
- D20 (
d85a2dc) — Docs drift: README/AGENTS/ADR forward-references annotated 📋 Planned.
Round-2 fold-in batch (13 findings):
- D21 (
1466d3a) — validateProvider enforces maxSpawnTimeMs contract field.
- D22 (
e10b7d7) — ADR 0004 Amendment 2: soft triggers deferred to v1.x.
- D23 (
7ef5510) — hints.cacheable opt-out + 10MB cache entry size cap (ADR 0002 Amendment 3, ADR 0005 Amendment 3).
- D24 (
f8348ad) — Spawn-timeout race fix: post-loop if (spawnTimedOut) throw SPAWN_TIMEOUT closes the rejectNext-null window across all 3 plugins.
- D25 (
cd391b1) — Round-2 P3 docs batch.
Round-3 fold-in batch (13 findings):
- D26 (
a281d3e) — Soft-trigger startup warning, stderr propagation on error-chunk SPAWN_FAILED (codex+mistral), anthropic D4-observation header, streaming truncation marker.
- D27 (
c3ba751) — IR validator response_format + tool_choice checks, ADR 0005 Amendment 4 (cache_control IR vs body), /v1/models alias surfacing.
- D28 (
4a238c9) — Per-hop log observability: chain_id, trigger_type, ir_request_hash, next_provider on all 8 fallback log events.
- D29 (
de9f3ca) — Suite 17 port-collision flake fix: 16 test sites switched to OS-assigned listen(0).
- D30 (
5119b42) — README env vars correctness, docs/openai-spec-pin.md v0.1 baseline.
- D31 (
d6347e3) — ADR amendment trio: F5 (ADR 0003 Amendment 1 substitute test strategy), F11 (ADR 0005 Amendment 5 Anthropic wire limitation), F13+F14 (ALIGNMENT.md Speculative-Candidate exception class).
Round-4 fold-in batch (10 findings):
- D32 (
30de965) — Provider auth env vars in README, X-OLP-* on early-return paths, ADR 0002 Amendment 4 ratifying contractVersion, dead OUTPUT_PARSE_ERROR removal, codex parser inline assumption labels.
Round-5 fold-in batch (12 findings):
- D33 (
f784fdb) — ALIGNMENT mistral --output streaming pin correction, deterministic function_call ID (cache key stability), /health per-provider snapshot, fallback-hop cache-hit X-OLP-Cache correctness, CLAUDE.md phase_rolling_mode policy formalization, /v1/models stable created timestamps.
Round-6 final batch (14 findings; 4 closed, 9 filed as issues):
- D34 (
60570ef) — ADR 0005 Amendment 6 (streaming singleflight v1.x deferral), array-field cache key normalization (tools:[] / stop:[] now collide with omitted), QUOTA_EXHAUSTED + RATE_LIMITED dead code removal (ADR 0004 Amendment 3), ADR 0005 Amendment 7 (conservative cache-key v0.1 trade-off).
ADRs in scope
- ADR 0001 — Project founding (Phase 1 founding doc; no amendments)
- ADR 0002 — Plugin architecture (4 amendments —
maxSpawnTimeMs, cacheable, contractVersion ratifications)
- ADR 0003 — IR design (1 amendment —
__irRoundTripTest removal + substitute test strategy)
- ADR 0004 — Fallback engine (3 amendments — SPAWN_FAILED salvage, soft trigger deferral, hard-trigger taxonomy narrowing)
- ADR 0005 — Cache layer (7 amendments — cache key expansions, cache_control IR-vs-body, cacheable + size cap, Anthropic wire limitation, streaming singleflight deferral, conservative cache-key v0.1 trade-off)
- ADR 0006 — Provider inclusion (Tier framework; no amendments)
- ALIGNMENT.md — Speculative-Candidate plugin Rule 4 exception class added (D31)
- CLAUDE.md —
phase_rolling_mode overlay added (D33)
docs/openai-spec-pin.md — v0.1 baseline pinned (D30)
Test growth
277 (pre-D10) → 416 (post-D34). 6 cold audit rounds reviewed code against ADR claims. Iron Rule v1.6 § 10.x dual-mode review discipline (Diff Review + Cold Audit) caught 78+ findings of which ~50 closed via implementation and ~28 deferred to GitHub issues.
Known limitations carried to v1.x
17 GitHub issues filed for follow-up. Notably:
- Streaming singleflight (#16) — multi-concurrent identical streaming requests each spawn fresh CLI; buffered path participates in D4, streaming path doesn't (deferred via ADR 0005 Amendment 6).
- maxConcurrent runtime enforcement (#1) — declarative-only at v0.1.
- X-OLP-Fallback-Detail debug header (#7) — documented in ADR 0004, never emitted.
- Soft triggers (per ADR 0004 Amendment 2) — evaluation code exists but
quotaStatus() polling not wired; configured thresholds inert at v0.1.
Migration from OCP
OLP supersedes OCP per ADR 0001. The scripts/migrate-from-ocp.mjs migration tool is 📋 Planned (Phase 7).
v0.1.0-bootstrap — 2026-05-23
Phase 0 — Repo bootstrap (founding + post-codex-review hardening)
This is the founding commit set of OLP (Open LLM Proxy), a personal- and family-scale multi-provider LLM proxy that supersedes OCP. The trigger was Anthropic's 2026-05-14 announcement (effective 2026-06-15) splitting claude -p / Agent SDK / third-party agent traffic out of the Pro/Max subscription pool into a separate fixed monthly Agent SDK Credit pool.
What lands at v0.1.0-bootstrap (final state on main as of 2026-05-23):
ALIGNMENT.md — OLP constitution. Three concurrent authorities (per-provider CLI / OpenAI spec / IR contract), 5 Rules, 4-tier Risk Tier Framework, Candidate-vs-Enabled provider inventory, one-shot triggered audits (2026-06-16 Anthropic post-split; 90-day Antigravity primary-source pin).
AGENTS.md — multi-tool agent guidelines (inherits ~/.cc-rules/AGENTS.md).
CLAUDE.md — Claude-Code-specific session instructions + machine-readable release_kit overlay (Iron Rule 5.5).
README.md — phase-aware skeleton with Candidate-vs-Enabled provider tables, API endpoint table, environment-variables table, response-headers spec, architecture overview, phase plan, migration-from-OCP outline. Placeholder content marked as such per phase.
docs/adr/ — 6 founding ADRs:
0001-project-founding.md — Mission, non-mission, narrow-scope supersession of OCP ADR 0005 (single-provider-sufficiency premise only; BYOK / no-spawn parts of ADR 0005 not inherited).
0002-plugin-architecture.md — lib/providers/<name>.mjs plug-in model with the Provider contract (name / models / auth / spawn / estimateCost / quotaStatus / healthCheck / hints). 8 candidate providers declared, 0 Enabled at v0.1.
0003-intermediate-representation.md — OLP-internal canonical IR between OpenAI-compat entry and provider plugins.
0004-fallback-engine.md — Trigger taxonomy (Hard / Soft / Deterministic-deferred / Cost-aware-deferred), idempotent-failure safety (first-chunk rule), chain advancement one-at-a-time, observability headers.
0005-cache-cross-provider.md — Cache key composition over (provider, model, messages, ...), D1+D2+D3+D4 port from OCP v3.13.0.
0006-provider-inclusion.md — 4-tier Risk Framework, Candidate-vs-Enabled distinction, 8-provider candidate classification, Antigravity Tier A (evidence-backed, pending primary-source pin) — exclusion rests on (named prohibition + no cost advantage + reinstatement friction) combination; primary-source URL not yet pinned, follow-up tracked.
.github/PULL_REQUEST_TEMPLATE.md — 8-radio Change Type taxonomy + per-type Authority Evidence sections + Iron Rule 10 reviewer checklist.
.github/workflows/alignment.yml — CI blacklist (transitive api.anthropic.com/api/oauth/usage from OCP 2026-04-11 drift; Antigravity provider exclusion enforcement) + models-registry.json validator + commit-citation soft check (process-substitution form, no Bash subshell trap).
.github/workflows/release.yml — Auto-release on tag push with package.json-vs-tag version match check (Iron Rule 5).
.github/workflows/test.yml — Node 20/24 matrix; tolerates bootstrap-phase absence of test-features.mjs AND scripts.test.
models-registry.json — minimal v0.1 stub with empty providers: {}, matching the 0-Enabled posture; populated by Phase audits as providers transition Candidate → Enabled.
package.json — minimal: no main, no scripts.test, no scripts.start (those entries land alongside the real files in Phase 1).
.gitignore, LICENSE (MIT), CHANGELOG.md — standard project boilerplate.
Provider posture at v0.1.0-bootstrap (per ALIGNMENT.md § Provider Inventory):
Tier
Anticipated providers
v0.1 default state
D (eligible-for-default-enabled)
Anthropic, OpenAI Codex, Mistral Vibe
Candidate (transition gate: authority pin + plugin + Phase audit)
C (opt-in)
xAI Grok, Moonshot Kimi
Candidate
B (opt-in + consent)
MiniMax, Zhipu GLM, Alibaba Qwen
Candidate
A (excluded by default; constitutional-amendment-only re-inclusion)
Google Antigravity
Excluded; pending primary-source pin
Total Enabled at v0.1.0-bootstrap: 0. Enablement is a Phase audit deliverable, not a bootstrap claim. This explicit zero is intentional and codified — a constitution that names providers as "default-enabled" while their CLI versions, output shapes, auth artifacts, and exit-code semantics are still TBD would violate Rules 1 (Cite First) and 3 (Match the Implementation).
Review history for this version:
-
Initial internal review (Claude Opus, fresh-context, Iron Rule 10). Verdict: APPROVE_WITH_MINOR — 2 minor items (alignment.yml heredoc indent breaking bash parse on failure path; AGENTS.md cross-reference to ADR 0003 imprecise). Both folded in before the founding commit.
-
External review #1 (OpenAI Codex CLI, no spec framing). Verdict: 6 substantive findings beyond internal review.
- Provider Inventory split into Candidate vs Enabled (the v0.1 constitution had declared
anthropic / openai / mistral as Tier D default-enabled while their Authority pins were still TBD at Phase N spawn — direct violation of Rule 1 / Rule 3 against the constitution's own text).
- Antigravity Tier A downgraded to "evidence-backed, pending primary-source pin" (secondary reports disagree on blast radius; Google FAQ URL not yet primary-source-pinned).
- ADR 0001 supersession scope narrowed (OLP rejects ADR 0005's "BYOK + no spawn" qualifiers, which originally applied to a commercial pivot; OLP is non-commercial and spawn-binary by design).
- Anthropic post-2026-06-15 one-shot audit scheduled (annual May 14 audit would leave Anthropic re-eval ~year late after the split takes effect).
- Tier A "permanent" language unified across docs (constitution and ADR 0006 had disagreed).
- OpenAI Tier D wording softened ("maintainer signal indicates low risk; formal ToS pin pending" — Discussion #8338 is a posture statement, not a formal ToS blessing).
-
External review #2 (OpenAI Codex CLI, second pass after review #1 fold-in). Verdict: 6 additional substantive findings — the self-consistency trap recurred when fold-in of review #1 was scoped only to files codex explicitly named. Round #2 caught:
- ADR 0002 still claimed "three default-enabled" while ALIGNMENT.md said zero Enabled — accepted ADR contradicting constitution.
release.yml would publish stale ## v0.1.0-bootstrap notes that ignored the "Unreleased" amendments — fixed by consolidating amendments into the v0.1.0-bootstrap section (this entry).
package.json advertised main / scripts.test / scripts.start for files that don't exist — npm test / npm start failed locally. Removed all three; will return in Phase 1 alongside the real files.
models-registry.json documented as SPOT but missing — minimal stub added.
alignment.yml commit-citation soft check had a Bash subshell trap (while in pipe loses WARN=1 mutation) — fixed via process substitution < <(...).
- Tier A "permanent" wording still inconsistent across
alignment.yml workflow text, ADR 0006 Consequences section, and the rest of the docs — unified throughout.
All 6 round-#2 findings folded in this consolidated v0.1.0-bootstrap state.
Reviewer framing learning (recorded permanently in ~/.cc-rules/memory/learnings/ai_reviewer_self_consistency_trap.md): Internal AI reviewers framed on a shared source-of-truth miss bugs in the source-of-truth itself. The self-consistency trap recurred during the fold-in of round #1 — when an external reviewer surfaces findings, the fold-in must grep the entire repo for the same concept, not only edit the files the reviewer named. Round #2 caught what round #1's fold-in missed for exactly this reason. Both lessons updated in the cross-machine memory.
Iron Rule 10 status: Satisfied. Initial reviewer = internal opus (independent from drafters). Round #1 reviewer = external codex (independent from drafters and from internal opus). Round #2 reviewer = external codex (independent from the round #1 fold-in implementer). The maintainer's role across all three reviews was approver, not author. The drafting agents and fold-in agents were never the same as the reviewers for any of the three passes.
Next: Phase 1 lands server.mjs skeleton + IR + Anthropic provider plugin + cache D1+D4 port from OCP. At that point, package.json regains main + scripts.test + scripts.start, test-features.mjs lands, models-registry.json populates its first providers.anthropic entry, and Anthropic transitions Candidate → Enabled. Per spec §6 phase plan.