mirror of
https://github.com/dtzp555-max/olp.git
synced 2026-07-21 21:15:10 +00:00
taodengandClaude Opus 4.8
349d35557b
External codex review (read-only) found 7 valid issues; all incorporated
(independently judged worth-keeping, none rejected):
P1 (must-fix before writing-plans):
- Billing wording downgraded: S1 proved cc_entrypoint=cli SIGNAL, not
actual subscription-pool billing (6/15 split hasn't happened). Banner
(a), §1.2, §10.2 now say "interactive-use signal; billing inference
pending post-6/15 validation; OCP canary is first real measurement."
- B gate semantics unified (was self-contradictory T2-only vs T2+T4):
now two-stage — no B before T2; serialized B (concurrency=1) after T2;
concurrent B only after T4. §5.2 + §7.3 + §12.
- B tools policy tightened to `--tools ""` strictly for initial B (was
allowing `--allowedTools subset`). Any subset voids the T2 tools:[]
proof + the owner-bearer credential wall (§5.5) → separate ADR. §5.2.
- PR-0 bootstrap made TUI-ONLY (gated on CLAUDE_TUI_MODE) so the seed
+ private account fields never touch the default stream-json path.
§7.1 + §12.1.
P2:
- Quiescence ("file stable ≥10s") REMOVED from v1 completion terminal
set — a long Opus thinking turn legitimately stalls transcript growth,
so quiescence would falsely abort valid long turns. v1 = turn_duration
+ tool_use + wall-clock cap only; quiescence deferred to T5. (This
corrects the T1 spike's own co-equal-quiescence suggestion.) §4.4.
- /mcp verification moved to a separate PREFLIGHT/upgrade-time session
(running it in a serving turn writes a transcript line + corrupts the
reader's matching-user-line semantics). §5.2.
- A warm-pool reconciled: reuse PROCESS not conversation context; fresh
--session-id (or /clear) per request to preserve OpenAI stateless
semantics. §2.1 + §7.2.
Reviewer credit: external codex review caught the v1-quiescence issue in
our own T1 spike output — incorporated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>