2 Commits

Include renames

Author	SHA1	Message	Date
taodengandClaude Opus 4.7 (noreply@anthropic.com)	c175e8994c	feat(phase-1): land Anthropic provider plugin (D4) ... Phase 1 Day 2. Anthropic provider plugin code lands, plus contractVersion field added across base.mjs and validated strictly. Anthropic stays CANDIDATE per ALIGNMENT.md Provider Inventory — D5 flips to Enabled after the real spawn E2E audit passes. POST /v1/chat/completions claude-* still returns 503 until then. Files: NEW: lib/providers/anthropic.mjs (445 lines) MOD: lib/providers/base.mjs (+8 lines — contractVersion enforcement) MOD: lib/providers/index.mjs (+37 lines — STATIC_REGISTRY adds anthropic + getProviderByName helper) MOD: models-registry.json — populates providers.anthropic with 3 models opus-4-7 / sonnet-4-6 / haiku-4-5, alias map, candidate marker MOD: test-features.mjs (+481 lines — Suite 6: 37 new tests covering contract conformance, contractVersion enforcement, IR translation, mock-spawn behaviour, healthCheck, estimateCost) Authority citations (all verified by independent reviewer against actual OCP byte offsets): Spawn pattern: OCP server.mjs:542 stdio shape, port verbatim. CLI args: OCP server.mjs:384-414 buildCliArgs pattern — -p, --model X, --output-format text, --no-session-persistence (session-resume and permissions branches stripped per OLP no-state architecture). stdin write: OCP server.mjs:586-587 verbatim. Stdout text handling: OCP server.mjs:735-748 raw d.toString per chunk no JSON envelope, matches --output-format text. Auth chain: OCP server.mjs:864-888 (env CLAUDE_CODE_OAUTH_TOKEN -> ~/.claude/.credentials.json -> macOS keychain with both label formats "claude-code-credentials" and "Claude Code-credentials") ported in same priority order. One delta vs OCP: OLP guards keychain branch on process.platform === darwin, OCP relies on try/catch on Linux. Both behave identically; OLP avoids an unnecessary shell-out. Env cleanup: OCP server.mjs:530-534 — delete CLAUDECODE, ANTHROPIC_ API_KEY, ANTHROPIC_BASE_URL, ANTHROPIC_AUTH_TOKEN. CLAUDECODE clobbering pitfall inherited per memory. Architectural decisions: 1. Anthropic stays Candidate at D4. STATIC_REGISTRY.length === 1 but loadProviders({}) returns empty Map. Suite 7 HTTP integration tests continue to verify 503 with no_enabled_provider for any claude-* model. D5 changes the config default to enable: { anthropic: true } and adds the real E2E spawn test. 2. contractVersion === 1.0 strictly enforced (F3 fold-in from D3 review). validateProvider in base.mjs rejects providers missing or having any other version string. Suite 6 includes 4 tests covering missing / 0.9 / 1.0 / undefined cases. 3. quotaStatus returns null at D4 with a TODO comment pointing at the ALIGNMENT.md 2026-06-16 one-shot audit. Anthropic Agent SDK Credit pool balance API has not been pinned; verification scheduled for 2026-06-16 per OLP one-shot audits. 4. estimateCost returns shape but usd: null. Per-million-token rates not pinned at D4. Lands when models-registry.json gains a pricing field in a later phase. 5. Lossy translations explicitly documented in anthropic.mjs file header per ADR 0003 § Lossy-translation documentation requirement. Includes response_format json_object (system-prompt augmented), top_p (no --top-p flag), tool_choice required (no flag), and request-level tools[] + assistant tool_calls + tool_call_id (text-in/text-out CLI cannot consume structured tool wire format). The tools[] documentation gap was a reviewer non-blocking finding; folded in this commit. Mocking discipline: no real claude -p spawn in any D4 test. spawn-path coverage uses __setSpawnImpl injection of fake child_process. No real OAuth tokens or API keys in fixtures — all use placeholder strings fake-oauth-token / fake-token. Auth path computed via path.join(homedir(), .claude, .credentials.json), no hardcoded /Users/<name> literal. Reviewer chain (Iron Rule 10): Implementer: sonnet (general-purpose). Fresh-context reviewer: opus (ecc:code-reviewer). Verdict APPROVE_WITH_MINOR. Reviewer ran npm test (98/98 pass) and verified all five OCP citations at the actual byte offsets in /Users/taodeng/ocp/server.mjs. All citations confirmed accurate. Reviewer non-blocking findings: 1. tools[] and tool_calls lossy-translation undocumented — FOLDED IN this commit (anthropic.mjs header rewritten with full lossy list). 2. with type json import attribute Node 20 compat — DEFERRED to CI verification. The syntax is stable on Node 20.10+ and the CI setup-node@v4 with node-version 20 resolves to latest 20.x. If CI Node 20 leg fails, mitigation is bump engines.node to >=20.10 or swap both import-attribute lines for readFileSync + JSON.parse. 3. CLI_NOT_FOUND error code declared but never thrown — DEFERRED to a future commit. Pure cosmetic; could distinguish ENOENT from generic spawn errors but no functional impact. Test count: 61 -> 98 (+37 D4 tests). Verification: node --check on all touched files: clean. npm test on Node 25.8.0: 98/98 pass in 209ms. Reviewer-run npm test independently: 98/98 pass. loadProviders({}) returns empty Map (verified by orchestrator and reviewer): Anthropic Candidate gate holds. hygiene grep: no personal names, no /Users/<name>/ literals, no real OAuth tokens or API keys. Co-Authored-By: Claude Opus 4.7 (noreply@anthropic.com)	2026-05-23 17:59:48 +10:00
taodengandClaude Opus 4.7 (noreply@anthropic.com)	dff428f3d0	docs(governance): fold in codex round-2 review findings (6 issues) ... External Codex CLI review pass 2 surfaced 6 substantive issues that round 1 fold-in missed — the self-consistency trap recurred when fold-in was scoped only to files codex explicitly named in round 1. This commit closes round 2 in full. 1. ADR 0002 contradicted ALIGNMENT.md (P1, codex round 2 finding 1) ADR 0002 still said "three default-enabled (Anthropic, OpenAI Codex, Mistral Vibe)" while ALIGNMENT.md (post round 1) said v0.1 ships zero Enabled Providers. Accepted ADR contradicted constitution. Fix: ADR 0002 + ADR 0001 + docs/adr/README.md index rewritten to Candidate framing. 2. release.yml would publish stale v0.1.0-bootstrap notes (P1, round 2 finding 2) The "Unreleased" amendments would have been silently dropped on tag push because release.yml extracts only the matching version section. Fix: CHANGELOG restructured so the amended state IS the v0.1.0- bootstrap section. Full review history (opus + 2 codex rounds) captured inline. 3. package.json advertised non-existent entrypoints (P2, round 2 finding 3) main/scripts.test/scripts.start pointed to files that do not exist. Local npm test and npm start failed; CI masked. Fix: remove all three from package.json. They return in Phase 1 alongside the real files. test.yml bootstrap-tolerance updated to also skip when scripts.test is absent. 4. models-registry.json missing despite SPOT claim (P2, round 2 finding 4) Fix: minimal stub committed (version + empty providers map). alignment.yml validator now actually runs. 5. alignment.yml commit-citation soft check Bash subshell trap (P2, round 2 finding 5) git log ... while read ... WARN=1 — the while loop ran in a subshell because of the pipe, so WARN never propagated out. The post-loop check always reported "clean" even when warnings fired. Fix: process substitution done less than less than (git log ...). 6. Tier A "permanent" wording inconsistent across ADR 0006 + alignment. yml workflow text (P3, round 2 finding 6) Fix: unified to "Excluded by default with no routine reinstatement path; re-inclusion requires ADR 0006 supersession or amendment with new primary-source evidence." Reviewer: OpenAI Codex CLI (external, fresh-context, pass 2). Iron Rule 10 satisfied — round 2 reviewer was not the implementer of round 1 fold-in. Memory learning updated: the self-consistency trap recurs in the fold-in step. Future fold-ins must grep the entire repo for the concept, not only edit files the reviewer named. See learnings/ai_reviewer_self_ consistency_trap.md in cross-machine memory. Co-Authored-By: Claude Opus 4.7 (noreply@anthropic.com)	2026-05-23 16:35:23 +10:00