mirror of
https://github.com/dtzp555-max/olp.git
synced 2026-07-19 09:45:07 +00:00
docs(providers): fix review-noted comment nits (dup token + OCP line-ref 783-784)
Independent review (Iron Rule 10) findings 1+2, both non-blocking comment-only. Co-Authored-By: Claude <claude-opus-4-8> <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude <claude-opus-4-8> <noreply@anthropic.com>
parent
422512d2b2
commit
2963547a98
@@ -980,7 +980,7 @@ async function* _spawnAndStream(irRequest, authContext, spawnImpl, isolationCtx)
|
||||
console.error(JSON.stringify({ ts: new Date().toISOString(), level: 'warn', event: 'stdin_write_error', error: e.message }));
|
||||
});
|
||||
}
|
||||
// OCP server.mjs:586-587: proc.stdin.write(prompt); proc.stdin.end();
|
||||
// OCP server.mjs:783-784: proc.stdin.write(prompt); proc.stdin.end();
|
||||
proc.stdin.write(prompt);
|
||||
proc.stdin.end();
|
||||
|
||||
|
||||
@@ -508,7 +508,7 @@ async function* _spawnAndStream(irRequest, authContext, spawnImpl, isolationCtx)
|
||||
// Guard stdin writes against EPIPE (child may close stdin before we finish
|
||||
// writing — e.g. on auth error, bad model, or oversized prompt).
|
||||
// Port of OCP server.mjs:780.
|
||||
// Authority: codex CLI Codex CLI reference (https://developers.openai.com/codex/cli/reference)
|
||||
// Authority: Codex CLI reference (https://developers.openai.com/codex/cli/reference)
|
||||
// observed behaviour — fast-failing spawn closes stdin before OLP finishes writing.
|
||||
// ALIGNMENT.md Rule 2: no CLI operation changed; guard is a Node stream safety net.
|
||||
// The typeof guard protects test-injected mock stdin objects that are plain
|
||||
|
||||
Reference in New Issue
Block a user