taodengandClaude Sonnet 4.6 7959f25801 fix(upgrade): error path completeness + observability ...

5 issues raised by code-quality reviewer on c12013a:

A. exec() wrapper now captures stderr from execSync failures and
   re-throws with `phase X failed: <stderr>` instead of the terse
   "Command failed: ..." default. Operators see the actual git/npm
   error.
B. runFullUpgrade body wrapped in try/catch; any error after phase 2
   (snapshot written) carries snapshotPath + phases + hint pointing
   at `ocp update --rollback`. Aligns with the post-flight failure
   pattern.
C. CLI entrypoint now prints snapshotPath + hint on error.

Plus minor:
- snapshot.mjs tryCopy logs a [snapshot] warn line instead of silently
  swallowing copy errors (e.g. permission-denied admin-key)
- heads-up window 1s → 3s, more operable per the policy intent
- opts.yes intent comment added (Bundle 3 will use)

One regression test added.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-11 03:58:32 +10:00

..

plist-merge.mjs

fix(setup): preserve user-customised plist/systemd env vars on re-setup (#90)

2026-05-11 03:41:53 +10:00

snapshot.mjs

fix(upgrade): error path completeness + observability

2026-05-11 03:58:32 +10:00